Skip to content

(8/n) Add ELO/Battles datasets as Task - #92

Open
kargibora wants to merge 4 commits into
refactor/task-yaml-pairwisefrom
refactor/task-yaml-elo
Open

(8/n) Add ELO/Battles datasets as Task#92
kargibora wants to merge 4 commits into
refactor/task-yaml-pairwisefrom
refactor/task-yaml-elo

Conversation

@kargibora

Copy link
Copy Markdown
Collaborator

Summary

This PR packages the ELO/arena benchmarks as declarative tasks, unifying them with the rest of the task system. ELO runs are now selected, validated, and configured the same way as every other benchmark instead of through special-cased code paths.

Previously, ELO was dispatched by matching a task-name prefix, arena datasets were downloaded through their own hardcoded path, and arena choices and dataset revisions lived in Python constants. Adding or changing an arena meant touching several unrelated files.

After this change, each arena is a task definition: elo-lmarena, elo-lmarena-100k, elo-lmarena-140k, and elo-comparia. The task YAML declares the arena, its pinned data sources, and its scoring defaults; the runtime resolves the task once and routes it through the shared benchmark registry.

What changed

  • ELO protocol schema. Task YAML can now declare an elo protocol (arena, judging, Bradley-Terry scoring defaults), validated like the pairwise and MT-Bench protocols.
  • Arena battles as a dataset kind. Battle datasets (model A vs. model B with a human winner) are a different contract than instruction datasets, so they get their own small adapter type. ELO tasks download and load their arena data through the same dataset registry as everything else.
  • One dispatch path. The task-name-prefix check for ELO is gone; the ELO runner is a regular registered benchmark.
  • Pins moved into task YAML. Arena dataset revisions previously kept in dataset_revisions.py now live with the task that uses them.
  • Config validation. Unknown task names are rejected at config time with a pointer to judgearena tasks list; ELO runtime settings (battle sampling, calibration, bootstraps) stay in the run config, while stable arena identity stays in the task YAML.

Define task-owned arena and scoring defaults while keeping the Bradley-Terry implementation behind a registered scorer.
Separate battle-backed datasets from instruction adapters and allow ELO tasks to load their pinned arena sources through the dataset registry.
Route ELO through the shared benchmark dispatcher using resolved task definitions, pinned arena sources, and task-selected scoring defaults.
judge_extra_kwargs already carries max_tokens from judge.model_kwargs(),
so passing it explicitly made every calibrate_temperature run crash with
'got multiple values for keyword argument max_tokens'. Matches the main
judge construction.
@geoalgo
geoalgo force-pushed the refactor/task-yaml-elo branch from 55cbf2b to 4ec6e12 Compare August 5, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant