Skip to content

Replace window.confirm calls with confirmation modals - #1698

Open
koki-star wants to merge 7 commits into
OpenEnergyDashboard:developmentfrom
koki-star:issue-1093-confirm-action-modals
Open

Replace window.confirm calls with confirmation modals#1698
koki-star wants to merge 7 commits into
OpenEnergyDashboard:developmentfrom
koki-star:issue-1093-confirm-action-modals

Conversation

@koki-star

@koki-star koki-star commented Aug 20, 2026

Copy link
Copy Markdown

Description

Fixes #1093

Author:

This replaces the seven remaining window.confirm calls with OED's existing ConfirmActionModalComponent. The changes cover group area calculations, group child compatibility warnings, meter displayable warnings, map deletion, and large raw-data exports.

The existing confirmation behavior, toast notifications, permissions, size checks, and download logic are preserved. The confirmation messages and buttons were also updated and translated where needed.

Testing completed:

  • Manually tested the Cancel and confirmation actions
  • npm run check
  • Docker test suite: 942 passing, 0 failing, and 1 pending

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

Limitations

None.

Screenshots

I tested all seven confirmation popups. Click each one to view the screenshot.

1. Create Group area create-group-area-confirmation-modal
2. Edit Group area edit-group-area-confirmation-modal
3. Group compatibility warning edit-group-child-compatibility-modal
4. Meter display warning meter-displayable-warning-modal
5. Delete Map map-delete-confirmation-modal
6. Export size warning export-size-warning-modal
7. Admin export limit admin-max-limit-confirmation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alerts need to be switched

1 participant