Changed visibility modifiers and moved code into seperate functions#15
Conversation
da-Kai
left a comment
There was a problem hiding this comment.
@Howaner
If you just want to test the changes first, I can have a snapshot built for you. However, Maven snapshots are only stored temporarily, so we would need to coordinate that.
If you’re not already familiar with it, I can also show you how to build the package locally and install it into your local Maven repo for testing.
I'm currently testing with a local OSGI repo (cnf/release), but it's a bit of pain to edit the index.xml file manually. I would be very grateful if you could show me how to do it with a local Maven repository. |
This makes it easier to unit test and it allows the injection of additional request/response types
7bcee9a to
dffc181
Compare
da-Kai
left a comment
There was a problem hiding this comment.
@Howaner
Noch eine Kleinigkeit, ansonsten würde ich mergen und einen Release erstellen, sobald @michaelgrill auch approved hat.
Ich geh davon aus, bei deinem Test hat alles soweit funktioniert.
da-Kai
left a comment
There was a problem hiding this comment.
hab doch noch was gefunden.
This makes it easier to unit test and it allows the injection of additional request/response types