Remove unused Linux struct metal_state members#361
Open
glneo wants to merge 3 commits into
Open
Conversation
Nothing in libmetal uses RNG. It is unexpected for an application calling metal_init() to have its RNG seed reset. An application for instance may want a static seed for testing. If an application wants a new random seed then it can set it itself. Setting global program state like this is not something that should be done unconditionally by libmetal. Signed-off-by: Andrew Davis <afd@ti.com>
This path was used to hold either /tmp or hugetlbfs_path, but it wasn't used in either case. It was also incorrectly labeled as holding sysfs path.. Drop this unused structure member. Signed-off-by: Andrew Davis <afd@ti.com>
Access to pagemap is restricted to only root or CAP_SYS_ADMIN making this open fail when applications are not run as root. The pagemap is only used when trying to do shmem and not all libmetal users need this. Only try to open pagemap when needed to remove warnings for non-shmem using apps. Signed-off-by: Andrew Davis <afd@ti.com>
Contributor
|
I plan to review this and #362 after the release |
arnopo
approved these changes
May 11, 2026
Contributor
arnopo
left a comment
arnopo
left a comment
There was a problem hiding this comment.
LGTM, I run few tests in Libmetal and system reference , no regression found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.