fix(atoms): replace top-level array state directly in signal.mutate#367
Open
fix(atoms): replace top-level array state directly in signal.mutate#367
Conversation
Previously, `signal.mutate(arr)` would recurse into the array and deep
merge its elements, unlike inner arrays which were replaced directly.
Now top-level arrays are replaced with a single `{ k: [], v }` transaction
that composes correctly through MappedSignal key prefixing.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signal.mutate(arr)now replaces the entire array instead of recursing into it and deep merging elements, matching the behavior of inner array replacements likesignal.mutate({ innerArr }){ k: [], v }transaction for top-level array replacements, which composes correctly through MappedSignal key prefixing ({ k: [] }→{ k: ['arr'] })Test plan
{ k: [], v }transaction🤖 Generated with Claude Code