Skip to content

Fix: settings window lifecycle to allow OBS system tray minimization - #98

Merged
campbellwmorgan merged 1 commit into
Off-World-Live:masterfrom
mrTomatolegit:fix/settings-lifecycle
Jul 3, 2026
Merged

campbellwmorgan merged 1 commit into
Off-World-Live:masterfrom
mrTomatolegit:fix/settings-lifecycle

Conversation

@mrTomatolegit

Copy link
Copy Markdown
Contributor
  • Correctly destroy settings window using WA_DeleteOnClose and destructor cleanup.
  • Simplify menu callback to focus or recreate window.

Resolves #87
Resolves #62

@campbellwmorgan campbellwmorgan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Thank you so much for submitting this PR. Codewise I think it looks good, but I'll have to clone in locally and test it before merging which I hope to do be able to do some time this week.

It seems like you've used spaces for indentation instead of tabs here and the code style isn't quite the same (ie scope { should appear below the text (ie if...\r{, not if ... { ). I appreciate that it is hard to know this as we haven't explicitly adopted a styleguide or have any editor guidance. [Edit] Sorry I realise that actually that you've done it correct to the CLang format that we added. Leave that as it is, but please use tabs instead of spaces.

Would you mind conforming your changes to that and then if the testing works out OK, i'll happily merge.

Thanks again

- Correctly destroy settings window using WA_DeleteOnClose and destructor cleanup.
- Simplify menu callback to focus or recreate window.
@campbellwmorgan

Copy link
Copy Markdown
Collaborator

@mrTomatolegit Thanks a lot for doing that so quickly. Will approve and merge as soon as I get a chance to test it properly :)

@campbellwmorgan campbellwmorgan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great. Thank you very much for the contribution.

@campbellwmorgan
campbellwmorgan merged commit 7e7abc1 into Off-World-Live:master Jul 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OBS 31.1.x + Spout2 installer → minimize-to-tray fails OBS won't go into system tray after getting this addon

2 participants