Skip to content

Fix docs: Correction to Substitute Variables in Templates#3207

Merged
Rose-Northey merged 3 commits into
mainfrom
rosen/correct-variable-for-substitution-failures
Jun 14, 2026
Merged

Fix docs: Correction to Substitute Variables in Templates#3207
Rose-Northey merged 3 commits into
mainfrom
rosen/correct-variable-for-substitution-failures

Conversation

@Rose-Northey

@Rose-Northey Rose-Northey commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

The docs were referencing Octopus.Action.Package.IgnoreVariableReplacementErrors on the Substitute Variables in Templates page, but that variable belongs to the XML/structured config features. The correct variable for this feature is OctopusShouldFailDeploymentOnSubstitutionFails, introduced in Calamari PR #1430.

The default behavior was also originally documented incorrectly. It was corrected so the user expects a their deployment to succeed by default and only fail if the variable is added.

Fixes this linear issue

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the “Substitute variables in templates” documentation to reference the correct variable that controls whether variable-substitution failures fail a deployment, aligning the docs with current Calamari/Octopus behavior.

Changes:

  • Updated the page to replace the incorrect variable (Octopus.Action.Package.IgnoreVariableReplacementErrors) with OctopusShouldFailDeploymentOnSubstitutionFails.
  • Corrected the documented default behavior to indicate deployments do not fail by default on substitution failures.
  • Updated the page modDate.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Rose-Northey Rose-Northey marked this pull request as draft June 12, 2026 03:07
@team-marketing-branch-protections

Copy link
Copy Markdown

Pull request environment is available at https://stoctodocspr3207.z22.web.core.windows.net.

You can view the ephemeral environment status in Octopus Deploy.

This environment will be automatically deprovisioned when the pull request is closed, or after 7 days of inactivity.

@mik-ky mik-ky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rose-Northey Rose-Northey force-pushed the rosen/correct-variable-for-substitution-failures branch from bda3e47 to 8a072ae Compare June 12, 2026 04:30
@Rose-Northey Rose-Northey requested a review from mik-ky June 12, 2026 04:47
@Rose-Northey Rose-Northey marked this pull request as ready for review June 14, 2026 21:46
@Rose-Northey Rose-Northey merged commit 8475cde into main Jun 14, 2026
7 checks passed
@Rose-Northey Rose-Northey deleted the rosen/correct-variable-for-substitution-failures branch June 14, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants