fix: include --waitfordeployment when a deployment timeout is set (#195)#202
Open
NickJosevski wants to merge 1 commit into
Open
fix: include --waitfordeployment when a deployment timeout is set (#195)#202NickJosevski wants to merge 1 commit into
NickJosevski wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-triggers release-please so the fix from #197 actually gets released.
Background
#197 was merged with a merge commit (
Merge pull request #197 …) rather than squash-merged like every other PR in this repo. release-please could not parse that commit, found 0 releasable commits since v6.4.1, and skipped — so no release PR was ever opened and the--waitfordeploymentfix is sitting onmainunreleased.The code change itself is already on
main(commit6fb361e); this PR adds nothing but a parseable Conventional Commit so release-please will cut the v6.4.2 release PR.How to merge
Squash-merge this (do not use a merge commit, or it'll be skipped again). The branch contains a single empty commit; squashing it lands a parseable
fix:commit onmain.After this: merge the resulting release-please PR → publish the GitHub Release → it builds & pushes to Octopus → promote Internal → External to ship to the JetBrains Marketplace.