Fix CA1416: mark IsRunningOnWindows as a platform guard#2017
Merged
Conversation
Annotate CalamariEnvironment.IsRunningOnWindows with
[SupportedOSPlatformGuard("windows")] so the platform-compatibility
analyzer recognises it as an OS guard. CA1416 only understands the BCL
guards (OperatingSystem.IsWindows() etc.), so it couldn't tell that
guarded call sites (e.g. File.Get/SetUnixFileMode in
DockerCredentialHelper) are unreachable on Windows.
The attribute is read from metadata, so this works cross-assembly and
clears the warning anywhere the property is used as a guard, without
changing the property's behaviour.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Jtango18
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
[SupportedOSPlatformGuard("windows")]toCalamariEnvironment.IsRunningOnWindows.Why
CA1416 (platform compatibility) fires at
DockerCredentialHelper.EnsureCredentialHelperIsExecutable, whereFile.GetUnixFileMode/File.SetUnixFileMode(both[UnsupportedOSPlatform("windows")]) are called. That method already guards with:…but the analyzer's flow analysis only recognises the BCL guards (
OperatingSystem.IsWindows(),RuntimeInformation.IsOSPlatform, or the platform attributes), so it couldn't tell the Unix-only calls are unreachable on Windows.SupportedOSPlatformGuardAttributeis the purpose-built way to teach the analyzer that a custom boolean member is an OS guard. It's read from metadata, so it works cross-assembly (the property lives inCalamari.Common, the call site inCalamari.Shared) and clears CA1416 anywhere the property is used as a guard — not just this one site.Impact
CalamariEnvironment.IsRunningOnWindowsrather than swapping inOperatingSystem.IsWindows()at each call site.Calamari.Sharedbuilds clean.🤖 Generated with Claude Code