Fix SYSLIB0013: use Uri.EscapeDataString for URL path segments#2016
Merged
Conversation
Uri.EscapeUriString is obsolete because it under-escapes — it leaves reserved characters (/, ?, #, etc.) unescaped, which can corrupt the request URL. The GitHub owner and repository values are individual URL path segments, so Uri.EscapeDataString is the correct replacement and also fixes the latent bug where a name containing a reserved character would break the constructed URL. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Jtango18
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the two obsolete
Uri.EscapeUriStringcalls inGitHubPackageDownloaderwithUri.EscapeDataStringwhen building the GitHub tags API URL.Why
Uri.EscapeUriStringis obsolete (SYSLIB0013) precisely because it under-escapes — it leaves reserved characters (/,?,#,&, etc.) unescaped. Theownerandrepositoryvalues are interpolated as individual URL path segments:$"repos/{owner}/{repository}/tags?..."Uri.EscapeDataStringis the documented correct replacement for URI components. This also fixes a latent bug: an owner/repo name containing a reserved character would previously corrupt the constructed URL.Impact
Calamari.Sharedbuilds clean.🤖 Generated with Claude Code