Repository navigation
Refresh DV-Pod - #128
Merged
Merged
Refresh DV-Pod#128
Conversation
Regenerate chart documentation with helm-docs to sync version badges with Chart.yaml files
Co-authored-by: obol-platform <139374357+obol-platform@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This merge integrates the targetConfigHash feature from feat/add-target-config-hash into the restructured dv-pod chart from oisin/podreview. Changes include: - Added charon.dkgSidecar.targetConfigHash parameter for specifying target cluster config hash - Added comprehensive validation for targetConfigHash format (0x + 64 hex chars) - Added test coverage: - test-target-config-hash-set.yaml: Verifies env var is set correctly - Updated test-dkg-sidecar-fresh-state.yaml: Includes targetConfigHash in tests - Added values-examples/with-target-config-hash.yaml: Usage example - Updated documentation in README.md (auto-generated via helm-docs) The merge resolved conflicts by: 1. Keeping the restructured values.yaml layout from oisin/podreview 2. Adding targetConfigHash to the existing charon.dkgSidecar section 3. Adding targetConfigHash test configuration 4. Regenerating all READMEs with helm-docs All validation tests pass: - Helm lint: ✓ - Pre-commit hooks: ✓ - Template rendering with valid hash: ✓ - Validation error handling: ✓
Resolved conflicts:
- charts/dv-pod/values.yaml: Removed duplicate targetConfigHash at line 555-557
(kept the one at line 543-545 which was properly positioned after operatorAddress)
- charts/dv-pod/README.md: Kept our version, verified helm-docs generates correctly
Verification:
- helm lint: ✓
- pre-commit hooks: ✓
- README.md.gotmpl: ✓ (in sync, uses {{ template "chart.valuesSection" . }})
bussyjd
approved these changes
Oct 9, 2025
apham0001
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the secret management for ENRs, particularly pre-created ones. It changes secret names and keys to match the default filename
charonoutputs, simplifying commands and removing gotchas. Also juggles the ordering of values.yaml to bring the most specific to this chart to the top, and updates some comments in the file.