Fix setup of partition IDs - #3037
Open
schaefi wants to merge 2 commits into
Open
Conversation
Collaborator
Author
|
@Conan-Kudo please wait with merging after my tests are complete |
Member
|
Do you have a test of an MBR-only image to verify? |
Collaborator
Author
We can add that. I added it here do the PR... still waiting for the tests to finish |
schaefi
force-pushed
the
fix_partition_id_for_lvm
branch
from
August 20, 2026 14:36
aad327b to
0311fb9
Compare
Collaborator
Author
schaefi
force-pushed
the
fix_partition_id_for_lvm
branch
from
August 20, 2026 15:02
0311fb9 to
0c250c5
Compare
When setting the partition type code (gUID, UUID) the partition id hex code gets resetted to Linux(83) when it should stay at the value it had before. This causes for example on LVM type(8e) partitions a reset to Linux(83) which is unwanted. With this commit we make sure the partition type hex code gets reset to the correct value. This Fixes #3036
Add a profile for building a DOS only LVM image and one with GPT
schaefi
force-pushed
the
fix_partition_id_for_lvm
branch
from
August 20, 2026 15:21
0c250c5 to
12e71c5
Compare
Collaborator
Author
|
@Conan-Kudo two images were built, please double check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting the partition type code (gUID, UUID) the partition id hex code gets resetted to Linux(83) when it should stay at the value it had before. This causes for example on LVM type(8e) partitions a reset to Linux(83) which is unwanted. With this commit we make sure the partition type hex code gets reset to the correct value. This Fixes #3036