Skip to content

feat: enforce SSL connections for all mysqli database interactions ac… #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pgeekay wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat: enforce SSL connections for all mysqli database interactions ac… #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f7ad67c
feat: enforce SSL connections for all mysqli database interactions ac…
pgeekay May 7, 2026
719f9c9
Error message print uncommented
pgeekay May 7, 2026
08c2c12
fix: comment out global log_bin_trust_function_creators configuration…
pgeekay May 7, 2026
079312a
refactor: comment out log_bin_trust_function_creators configuration a…
pgeekay May 7, 2026
d36bfa8
chore: comment out MySQL event scheduler and SQL mode configuration s…
pgeekay May 7, 2026
da9f636
feat: update database connection to use SSL for improved security dur…
pgeekay May 7, 2026
a2cc703
feat: enforce SSL connections for all MySQL database interactions
pgeekay May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ConnectionClass.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ function init($DatabaseServer, $DatabaseUsername, $DatabasePassword, $DatabaseNa
{
$user_agent = explode('/', isset($_SERVER['HTTP_USER_AGENT']) ? $_SERVER['HTTP_USER_AGENT'] : '');
if (isset($user_agent[0]) && $user_agent[0] == 'Mozilla') {
$conn = new mysqli($DatabaseServer, $DatabaseUsername, $DatabasePassword, $DatabaseName);
$conn = mysqli_init();
$conn->ssl_set(NULL, NULL, NULL, NULL, NULL);
$conn->real_connect($DatabaseServer, $DatabaseUsername, $DatabasePassword, $DatabaseName, 3306, null, MYSQLI_CLIENT_SSL);
// Disable strict mode to ensure compatibility
if ($conn && !$conn->connect_errno) {
$conn->query("SET SESSION sql_mode = ''");
Expand Down
4 changes: 3 additions & 1 deletion DatabaseInc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ function db_start()


##### Connection help #####
/*
if (!empty($DatabaseServer) && !empty($DatabaseUsername) && !empty($DatabaseName))
$connection = mysqli_connect($DatabaseServer, $DatabaseUsername, $DatabasePassword, $DatabaseName);

Expand All @@ -80,11 +81,12 @@ function db_start()
if ($result && mysqli_num_rows($result) > 0) {
$row = mysqli_fetch_assoc($result);
if ((int)$row['lbtfc'] !== 1) {
$connection->query("SET @@GLOBAL.log_bin_trust_function_creators = 1");
// $connection->query("SET @@GLOBAL.log_bin_trust_function_creators = 1");
}
}
}
}
*/

# ---------- #
# Debugger #
Expand Down
4 changes: 3 additions & 1 deletion ForgotPass.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ function db_start() {

switch ($DatabaseType) {
case 'mysqli':
$connection = new mysqli($DatabaseServer, $DatabaseUsername, $DatabasePassword, $DatabaseName);
$connection = mysqli_init();
$connection->ssl_set(NULL, NULL, NULL, NULL, NULL);
$connection->real_connect($DatabaseServer, $DatabaseUsername, $DatabasePassword, $DatabaseName, 3306, null, MYSQLI_CLIENT_SSL);
break;
}

Expand Down
8 changes: 6 additions & 2 deletions PasswordCheck.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ function db_start()
switch($DatabaseType)
{
case 'mysqli':
$connection = new mysqli($DatabaseServer,$DatabaseUsername,$DatabasePassword,$DatabaseName);
$connection = mysqli_init();
$connection->ssl_set(NULL, NULL, NULL, NULL, NULL);
$connection->real_connect($DatabaseServer, $DatabaseUsername, $DatabasePassword, $DatabaseName, 3306, null, MYSQLI_CLIENT_SSL);
break;
}
// Error code for both.
Expand All @@ -56,7 +58,9 @@ function db_start()


##### Connection help #####
$connection = mysqli_connect($DatabaseServer, $DatabaseUsername, $DatabasePassword, $DatabaseName);
$connection = mysqli_init();
$connection->ssl_set(NULL, NULL, NULL, NULL, NULL);
$connection->real_connect($DatabaseServer, $DatabaseUsername, $DatabasePassword, $DatabaseName, 3306, null, MYSQLI_CLIENT_SSL);

if (!$connection)
{
Expand Down
6 changes: 4 additions & 2 deletions install/Ins1.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,11 @@
</html>';
//$dbconn = mysqli_connect($_SESSION['host'],$_SESSION['username'],$_SESSION['password'])
try{
$dbconn = new mysqli($_SESSION['server'], $_SESSION['username'], $_SESSION['password'], '', $_SESSION['port']);
$dbconn = mysqli_init();
$dbconn->ssl_set(NULL, NULL, NULL, NULL, NULL);
$dbconn->real_connect($_SESSION['server'], $_SESSION['username'], $_SESSION['password'], '', $_SESSION['port'], null, MYSQLI_CLIENT_SSL);
} catch (Exception $e) {
// echo 'Caught exception: ', $e->getMessage(), "\n";
echo 'Caught exception: ', $e->getMessage(), "\n";
exit($err);
}
if ($dbconn->connect_errno != 0) {
Expand Down
10 changes: 6 additions & 4 deletions install/Ins2.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,12 @@

// Helper function to create mysqli connection with strict mode disabled
function createConnection($server, $username, $password, $database = '', $port = 3306) {
$conn = mysqli_init();
$conn->ssl_set(NULL, NULL, NULL, NULL, NULL);
if ($database != '') {
$conn = new mysqli($server, $username, $password, $database, $port);
$conn->real_connect($server, $username, $password, $database, $port, null, MYSQLI_CLIENT_SSL);
} else {
$conn = new mysqli($server, $username, $password, '', $port);
$conn->real_connect($server, $username, $password, '', $port, null, MYSQLI_CLIENT_SSL);
}
if ($conn && !$conn->connect_errno) {
$conn->query("SET SESSION sql_mode = ''");
Expand Down Expand Up @@ -188,7 +190,7 @@ function executeSQL($myFile)
$dbconn = createConnection($_SESSION['server'], $_SESSION['username'], $_SESSION['password'], $_SESSION['db'], $_SESSION['port']);

// Enable function creation with binary logging
$dbconn->query("SET GLOBAL log_bin_trust_function_creators = 1");
// $dbconn->query("SET GLOBAL log_bin_trust_function_creators = 1");

$sql = file_get_contents($myFile);
$sqllines = par_spt("/[\n]/", $sql);
Expand Down Expand Up @@ -223,7 +225,7 @@ function createUpdatedByTriggers()
$dbconn = createConnection($_SESSION['server'], $_SESSION['username'], $_SESSION['password'], $_SESSION['db'], $_SESSION['port']);

// Enable trigger/function creation with binary logging
$dbconn->query("SET GLOBAL log_bin_trust_function_creators = 1");
// $dbconn->query("SET GLOBAL log_bin_trust_function_creators = 1");

if ($result = $dbconn->query("SELECT DISTINCT TABLE_NAME
FROM INFORMATION_SCHEMA.COLUMNS
Expand Down
6 changes: 4 additions & 2 deletions install/Ins3.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@

// Helper function to create mysqli connection with strict mode disabled
function createConnectionIns3($server, $username, $password, $database = '', $port = 3306) {
$conn = new mysqli($server, $username, $password, $database, $port);
$conn = mysqli_init();
$conn->ssl_set(NULL, NULL, NULL, NULL, NULL);
$conn->real_connect($server, $username, $password, $database, $port, null, MYSQLI_CLIENT_SSL);
if ($conn && !$conn->connect_errno) {
$conn->query("SET SESSION sql_mode = ''");
}
Expand Down Expand Up @@ -106,7 +108,7 @@ function executeSQL($myFile)
$dbconn = createConnectionIns3($_SESSION['server'],$_SESSION['username'],$_SESSION['password'],$_SESSION['db'],$_SESSION['port']);

// Enable trigger/function creation with binary logging
$dbconn->query("SET GLOBAL log_bin_trust_function_creators = 1");
// $dbconn->query("SET GLOBAL log_bin_trust_function_creators = 1");

$sql = file_get_contents($myFile);
$sqllines = par_spt("/[\n]/",$sql);
Expand Down
4 changes: 3 additions & 1 deletion install/Ins4.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@

require_once "../functions/PragRepFnc.php";
//mysql_select_db($_SESSION['db']);
$dbconn = new mysqli($_SESSION['server'],$_SESSION['username'],$_SESSION['password'],$_SESSION['db'],$_SESSION['port']);
$dbconn = mysqli_init();
$dbconn->ssl_set(NULL, NULL, NULL, NULL, NULL);
$dbconn->real_connect($_SESSION['server'],$_SESSION['username'],$_SESSION['password'],$_SESSION['db'],$_SESSION['port'], null, MYSQLI_CLIENT_SSL);
if ($dbconn && !$dbconn->connect_errno) {
$dbconn->query("SET SESSION sql_mode = ''");
}
Expand Down
6 changes: 3 additions & 3 deletions install/OpensisProcsMysqlInc.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,9 +794,9 @@ DELIMITER ;
-- EVENT: SET EVENT SCHEDULER ON TEMPORARILY. TO DO IT PERMANENTLY, YOU NEED TO SET THE MYSQL CONFIG
--

SET @@GLOBAL.event_scheduler = ON;
SET GLOBAL log_bin_trust_function_creators = 1;
SET @@GLOBAL.SQL_MODE = "NO_ENGINE_SUBSTITUTION";
-- SET @@GLOBAL.event_scheduler = ON;
-- SET GLOBAL log_bin_trust_function_creators = 1;
-- SET @@GLOBAL.SQL_MODE = "NO_ENGINE_SUBSTITUTION";

--
-- EVENT: ES_HANDLER_MISSING_ATTENDANCE
Expand Down
4 changes: 2 additions & 2 deletions install/OpensisUpdateProcsMysql.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,8 +718,8 @@ DELIMITER ;
-- EVENT: SET EVENT SCHEDULER ON TEMPORARILY. TO DO IT PERMANENTLY, YOU NEED TO SET THE MYSQL CONFIG
--

SET @@GLOBAL.event_scheduler = ON;
SET GLOBAL log_bin_trust_function_creators = 1;
-- SET @@GLOBAL.event_scheduler = ON;
-- SET GLOBAL log_bin_trust_function_creators = 1;

--
-- EVENT: ES_HANDLER_MISSING_ATTENDANCE
Expand Down
6 changes: 4 additions & 2 deletions install/Selectdb.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,12 @@

// Helper function to create mysqli connection with strict mode disabled
function createConnectionSelectDb($server, $username, $password, $database = '', $port = 3306) {
$conn = mysqli_init();
$conn->ssl_set(NULL, NULL, NULL, NULL, NULL);
if ($database != '') {
$conn = new mysqli($server, $username, $password, $database, $port);
$conn->real_connect($server, $username, $password, $database, $port, null, MYSQLI_CLIENT_SSL);
} else {
$conn = new mysqli($server, $username, $password);
$conn->real_connect($server, $username, $password, '', $port, null, MYSQLI_CLIENT_SSL);
}
if ($conn && !$conn->connect_errno) {
$conn->query("SET SESSION sql_mode = ''");
Expand Down
4 changes: 3 additions & 1 deletion install/SqlForClientSchoolAndSampleDataInc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1640,7 +1640,9 @@
(5, 'admin', 'Admin Asst', '2019-07-28 08:26:33', NULL),
(6, 'admin', 'Test', '2022-10-13 22:08:47', NULL);";

$dbconn = new mysqli($_SESSION['server'],$_SESSION['username'],$_SESSION['password'],$_SESSION['db'],$_SESSION['port']);
$dbconn = mysqli_init();
$dbconn->ssl_set(NULL, NULL, NULL, NULL, NULL);
$dbconn->real_connect($_SESSION['server'],$_SESSION['username'],$_SESSION['password'],$_SESSION['db'],$_SESSION['port'], null, MYSQLI_CLIENT_SSL);
if ($dbconn && !$dbconn->connect_errno) {
$dbconn->query("SET SESSION sql_mode = ''");
}
Expand Down
4 changes: 3 additions & 1 deletion install/SqlForClientSchoolInc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,9 @@

INSERT INTO `user_profiles` (`id`, `profile`, `title`, `last_updated`, `updated_by`) VALUES (1,'admin','Administrator','2019-07-28 08:26:33',NULL),(2,'teacher','Teacher','2019-07-28 08:26:33',NULL),(3,'student','Student','2019-07-28 08:26:33',NULL),(4,'parent','Parent','2019-07-28 08:26:33',NULL),(5,'admin','Admin Asst','2019-07-28 08:26:33',NULL);";

$dbconn = new mysqli($_SESSION['server'],$_SESSION['username'],$_SESSION['password'],$_SESSION['db'],$_SESSION['port']);
$dbconn = mysqli_init();
$dbconn->ssl_set(NULL, NULL, NULL, NULL, NULL);
$dbconn->real_connect($_SESSION['server'],$_SESSION['username'],$_SESSION['password'],$_SESSION['db'],$_SESSION['port'], null, MYSQLI_CLIENT_SSL);
if ($dbconn && !$dbconn->connect_errno) {
$dbconn->query("SET SESSION sql_mode = ''");
}
Expand Down
4 changes: 3 additions & 1 deletion install/SqlSampleDataInc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1590,7 +1590,9 @@
(5, 'admin', 'Admin Asst', '2019-07-28 08:26:33', NULL),
(6, 'admin', 'Test', '2022-10-13 22:08:47', NULL);";

$dbconn = new mysqli($_SESSION['server'],$_SESSION['username'],$_SESSION['password'],$_SESSION['db'],$_SESSION['port']);
$dbconn = mysqli_init();
$dbconn->ssl_set(NULL, NULL, NULL, NULL, NULL);
$dbconn->real_connect($_SESSION['server'],$_SESSION['username'],$_SESSION['password'],$_SESSION['db'],$_SESSION['port'], null, MYSQLI_CLIENT_SSL);
if ($dbconn && !$dbconn->connect_errno) {
$dbconn->query("SET SESSION sql_mode = ''");
}
Expand Down