Remove GridElement class#423
Merged
Merged
Conversation
4a7e05b to
71ffae3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplify inheritance structure for
PhasorDynamicsbuses and components.Proposed changes
Remove intermediary
GridElementclass and let BusBase inherit directly fromEvaluator. While this does introduce some minor code duplication, we expect bus and component classes to get more specialized and the common code between them to change going forward. As we move to implement EMT models, having simpler inheritance structure will help, as well.Also, I expect
BusBaseclass to be removed altogether and haveBusinherit directly fromEvaluator. ClassBusInfiniteshould be a standalone class, similar toSignalNodeand not inherit fromEvaluatorat all.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments