Skip to content

Remove GridElement class#423

Merged
pelesh merged 5 commits into
developfrom
slaven/simplify-pd-inheritance
Jun 2, 2026
Merged

Remove GridElement class#423
pelesh merged 5 commits into
developfrom
slaven/simplify-pd-inheritance

Conversation

@pelesh
Copy link
Copy Markdown
Collaborator

@pelesh pelesh commented May 31, 2026

Description

Simplify inheritance structure for PhasorDynamics buses and components.

Proposed changes

Remove intermediary GridElement class and let BusBase inherit directly from Evaluator. While this does introduce some minor code duplication, we expect bus and component classes to get more specialized and the common code between them to change going forward. As we move to implement EMT models, having simpler inheritance structure will help, as well.

Also, I expect BusBase class to be removed altogether and have Bus inherit directly from Evaluator. Class BusInfinite should be a standalone class, similar to SignalNode and not inherit from Evaluator at all.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

@pelesh pelesh self-assigned this May 31, 2026
@pelesh pelesh added the cleanup label May 31, 2026
@pelesh pelesh force-pushed the slaven/simplify-pd-inheritance branch from 4a7e05b to 71ffae3 Compare June 2, 2026 04:04
Copy link
Copy Markdown
Collaborator

@PhilipFackler PhilipFackler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works :)

@pelesh pelesh merged commit faa112f into develop Jun 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants