Skip to content

Send new supporters to email preferences after signup - #4830

Merged
jproberson merged 2 commits into
masterfrom
fix/supporter-email-preferences-redirect
Aug 16, 2026
Merged

Send new supporters to email preferences after signup#4830
jproberson merged 2 commits into
masterfrom
fix/supporter-email-preferences-redirect

Conversation

@jproberson

Copy link
Copy Markdown
Contributor

PR Checklist

  • - Unit and/or e2e tests for the changes that have been added (for bug fixes / features)

What kind of change does this PR introduce?

  • 🐛 Bugfix — fixes incorrect behavior without changing functionality
  • ✨ Feature — adds new functionality
  • ♻️ Refactoring — improves code structure with no functional changes
  • ⚡️ Performance — improves speed, memory, or efficiency
  • 🧪 Tests — adds or updates tests only
  • 🔧 Tools / CI — changes to build, deploy, or developer tooling
  • 📝 Documentation — updates docs, comments, or READMEs
  • 📦 Dependencies — upgrades, downgrades, or removes packages
  • 🔖 Other:

What is the new behavior?

Signing up with the supporter flow did not provide the redirect link to the setup-email-preferences page

Does this PR introduce a DB Schema Change or Migration?

  • Yes
  • No

Git Issues

Closes #

What happens next?

Thank you for the contribution! We will review it ASAP.

If you need more immediate feedback you can reach out to us on Discord in the Community Platform development channel.

@cypress

cypress Bot commented Aug 10, 2026

Copy link
Copy Markdown

onearmy-community-platform    Run #9896

Run Properties:  status check passed Passed #9896  •  git commit a63b6b7c75: update test
Project onearmy-community-platform
Branch Review fix/supporter-email-preferences-redirect
Run status status check passed Passed #9896
Run duration 10m 33s
Commit git commit a63b6b7c75: update test
Committer Jacob Roberson
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 115
View all changes introduced in this branch ↗︎

@mariojsnunes

Copy link
Copy Markdown
Contributor

@jproberson is this ready?

@jproberson
jproberson marked this pull request as ready for review August 16, 2026 13:10
@jproberson
jproberson requested a review from a team as a code owner August 16, 2026 13:10
@jproberson

Copy link
Copy Markdown
Contributor Author

@mariojsnunes should be ready, looks like it might have some conflicts but I can't see them in the gh phone app. I'll take a look at it when I get back home this evening.

@jproberson
jproberson force-pushed the fix/supporter-email-preferences-redirect branch from 7970ff2 to a63b6b7 Compare August 16, 2026 20:53
@jproberson
jproberson merged commit 573e860 into master Aug 16, 2026
12 checks passed
@jproberson
jproberson deleted the fix/supporter-email-preferences-redirect branch August 16, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants