Skip to content

feat: add marker styling for selected pin - #4799

Open
benfurber wants to merge 1 commit into
masterfrom
feat/add-marker-selected-styling
Open

feat: add marker styling for selected pin#4799
benfurber wants to merge 1 commit into
masterfrom
feat/add-marker-selected-styling

Conversation

@benfurber

Copy link
Copy Markdown
Member

What is the new behavior?

Add basic styling for a selected map pin. Could be enhanced in the future, but even getting it to this point was a suprising amount of work with a lot of trial and error.

Screen.Recording.2026-07-07.at.15.08.50.mov

Does this PR introduce a DB Schema Change or Migration?

  • Yes
  • No

Git Issues

Closes #3854 #3854

@benfurber
benfurber requested a review from a team as a code owner July 7, 2026 14:25
@benfurber
benfurber force-pushed the feat/add-marker-selected-styling branch 2 times, most recently from 9a73163 to 29fe26c Compare July 7, 2026 14:47
@cypress

cypress Bot commented Jul 7, 2026

Copy link
Copy Markdown

onearmy-community-platform    Run #9779

Run Properties:  status check failed Failed #9779  •  git commit e751119402: feat: add marker styling for selected pin
Project onearmy-community-platform
Branch Review feat/add-marker-selected-styling
Run status status check failed Failed #9779
Run duration 03m 21s
Commit git commit e751119402: feat: add marker styling for selected pin
Committer Ben Furber
View all properties for this run ↗︎

Test results
Tests that failed  Failures 28
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 75
Tests that passed  Passing 0
View all changes introduced in this branch ↗︎

Tests for review

Failed  research/write.spec.ts • 1 failed test • ci-electron

View Output Video

Test Artifacts
[Research] > [Create research article] > [By Authenticated] Test Replay Screenshots Video
Failed  profile.spec.ts • 1 failed test • ci-electron

View Output Video

Test Artifacts
[Profile] > [By Anonymous] > [Can view all public profile information] Test Replay Screenshots Video
Failed  library/write.spec.ts • 1 failed test • ci-electron

View Output Video

Test Artifacts
[Library] > [Create a project] > [By Authenticated] Test Replay Screenshots Video
Failed  news/write.spec.ts • 1 failed test • ci-electron

View Output Video

Test Artifacts
[News.Write] > Create and update Test Replay Screenshots Video
Failed  questions/discussions.spec.ts • 1 failed test • ci-electron

View Output Video

Test Artifacts
[Questions.Discussions] > shows existing comments Test Replay Screenshots Video

The first 5 failed specs are shown, see all 28 specs in Cypress Cloud.

@davehakkens

Copy link
Copy Markdown
Contributor

why does your map card chop of the avatar?
image

@benfurber
benfurber force-pushed the feat/add-marker-selected-styling branch from 29fe26c to a9dd2b8 Compare July 7, 2026 15:23
@davehakkens davehakkens added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Jul 7, 2026
@benfurber

Copy link
Copy Markdown
Member Author

why does your map card chop of the avatar? image

Unrelated to anything I've touched.

@benfurber
benfurber force-pushed the feat/add-marker-selected-styling branch from a9dd2b8 to ff75d72 Compare July 7, 2026 15:32
@davehakkens

davehakkens commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

what data do you use?
Its a machine shop icon with a member profile layout. Is it special testing data?

image

@mariojsnunes

mariojsnunes commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

I wonder if it's possible to do this without having to set the background color for the icon on the database. it will be annoying to maintain.

Edit: Doesn't seem to be possible.

@benfurber if it's not configured, it should behave same as before this PR.

@mariojsnunes

Copy link
Copy Markdown
Contributor

Maybe we could just make the selected pin bigger or highlighted in some other way. To avoid the extra database configuration.

@benfurber

Copy link
Copy Markdown
Member Author

Maybe we could just make the selected pin bigger or highlighted in some other way. To avoid the extra database configuration.

@davehakkens What do you think? Pro of this is that it's easier to maintain (e.g. it won't really need to be changed again). Con is I've done this work already(!)

@davehakkens

Copy link
Copy Markdown
Contributor

How much work/hours went in it? @benfurber

@mariojsnunes

Copy link
Copy Markdown
Contributor

I think the question should be:

  1. design and implement another style that doesn't require the background color db setting
  2. or maintain the setting for the foreseeable future

Having work done (although it would feel bad to throw away) is not that relevant and some of it can be reused.

@benfurber benfurber moved this to In progress in Core Team - BAU list Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview

Projects

Status: No status
Status: In progress

Development

Successfully merging this pull request may close these issues.

feat: update map pin icons

3 participants