Skip to content

fix img src and max-height#244

Open
lena-hinrichsen wants to merge 2 commits into
masterfrom
web_api-update
Open

fix img src and max-height#244
lena-hinrichsen wants to merge 2 commits into
masterfrom
web_api-update

Conversation

@lena-hinrichsen

Copy link
Copy Markdown
Member

No description provided.

@lena-hinrichsen lena-hinrichsen requested a review from kba March 24, 2023 10:35

@kba kba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why, what is the probelm with <figure/>?

@lena-hinrichsen

lena-hinrichsen commented Mar 24, 2023

Copy link
Copy Markdown
Member Author

Why, what is the probelm with <figure/>?

The class does not neccessarily have to be changed, as it seems. that happened when I copy pasted a block from another page (about) where we use figure img.

The important change is the image src, max-height and the href I think

@kba kba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I was just curious, looks legit otherwise, feel free to publish

@kba kba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not realize this is OCR-D/spec not OCR-D/website. I need to adapt make spec in OCR-D/website, please don't merge for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants