[16.0][FIX] fs_attachment,fs_attachment_s3,fs_storage,fs_storage_backup: fix server_environment split migration and add install/uninstall hooks - #653
Merged
Conversation
Contributor
|
Hi @lmignon, |
yankinmax
force-pushed
the
fix-storage-split
branch
2 times, most recently
from
August 19, 2026 13:38
9e480a4 to
a43356e
Compare
ivantodorovich
approved these changes
Aug 19, 2026
yankinmax
force-pushed
the
fix-storage-split
branch
from
August 19, 2026 14:12
a43356e to
281121d
Compare
Contributor
|
I haven't had any upgrade issues with the current implementation.... which doesn't mean the fix doesn't improve the robustness of the approach. |
3 tasks
Author
|
|
lmignon
approved these changes
Aug 20, 2026
yankinmax
force-pushed
the
fix-storage-split
branch
2 times, most recently
from
August 24, 2026 06:51
b507434 to
c446ed5
Compare
Author
|
To be able to fix the issue we need to merge the dependencies, because they're conflicting now: UPDATE |
yankinmax
force-pushed
the
fix-storage-split
branch
3 times, most recently
from
August 24, 2026 13:36
37afa2e to
47f925c
Compare
…lumns on uninstall
… columns on uninstall
…ore columns on uninstall
…tore columns on uninstall
yankinmax
force-pushed
the
fix-storage-split
branch
from
August 25, 2026 05:28
47f925c to
4e42d9d
Compare
Contributor
|
/ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 3fae9b1. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR was merged:
This PR fixes the broken migration scripts, which set
ir_module_module::statedirectly via SQL instead of callingbutton_install, so the new*_environmentmodules never actually got installed on upgrade.Scripts are moved to the
upgrades/folder (same version, no version bump) and fixed to callbutton_install.Also adds
uninstall_hookto each*_environment module, usingrestore_env_managed_columnsfromserver_environmentto restore the DB columns dropped byserver.env.mixinwhen the module is uninstalled.Depends on: