Skip to content

[18.0] [FIX] server_environment: no interpolation in the configparser #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AxelPrel wants to merge 2 commits into
base: 18.0
Choose a base branch
from
Open

[18.0] [FIX] server_environment: no interpolation in the configparser #266

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82973d6
[FIX] server_environment: no interpolation in the configparser
AxelPrel May 20, 2026
31497e6
[IMP] server_environment: configparser interpolation is configurable …
AxelPrel May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions server_environment/readme/newsfragments/265.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
remove interpolation in the configparser
2 changes: 1 addition & 1 deletion server_environment/server_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def _load_config_from_env(config_p):

def _load_config():
"""Load the configuration and return a ConfigParser instance."""
config_p = configparser.ConfigParser()
config_p = configparser.ConfigParser(interpolation=None)
# options are case-sensitive
config_p.optionxform = str

Expand Down
2 changes: 1 addition & 1 deletion server_environment/tests/test_server_environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def test_value_retrieval(self):
with self.set_config_dir("testfiles"):
parser = server_env._load_config()
val = parser.get("external_service.ftp", "user")
self.assertEqual(val, "testing")
self.assertEqual(val, "testing%")
val = parser.get("external_service.ftp", "host")
self.assertEqual(val, "sftp.example.com")

Expand Down
2 changes: 1 addition & 1 deletion server_environment/tests/testfiles/testing/base.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
odoo_test_option = Set in config file for testing env

[external_service.ftp]
user = testing
user = testing%
Loading