Skip to content

[19.0][MIG] l10n_it_financial_statements_report: Migration to 19.0 - #5345

Open
eLBati wants to merge 26 commits into
OCA:19.0from
eLBati:19.0-mig-l10n_it_financial_statements_report-lb
Open

[19.0][MIG] l10n_it_financial_statements_report: Migration to 19.0#5345
eLBati wants to merge 26 commits into
OCA:19.0from
eLBati:19.0-mig-l10n_it_financial_statements_report-lb

Conversation

@eLBati

@eLBati eLBati commented Oct 1, 2026

Copy link
Copy Markdown
Member

Supersedes #5086 by @Borruso, rebased on current 19.0.

Changes on top of #5086:

  • Remove the xlrd==1.2.0 external dependency: xlrd is only used by the tests, and report_xlsx already depends on it. Odoo 19 checks the version of external_dependencies when installing a module, and
    on Python ≥ 3.12 it installs xlrd 2.0.1, so the pin made the module impossible to install there. The XLSX test now uses openpyxl.
  • The rebase also resolves the conflict on requirements.txt.

SirTakobi and others added 23 commits October 1, 2026 16:37
@SirTakobi @eLBati
[REF] l10n_it_account_balance_report: Rename
569dfb8 
Balance is too generic, Financial statements is what this module is producing
@francesco-ooops @eLBati
Translated using Weblate (Italian)
85d9e9f 
Currently translated at 100.0% (74 of 74 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_financial_statements_report
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_financial_statements_report/it/
@SirAionTech @eLBati
[IMP] l10n_it_financial_statements_report: pre-commit execution
a4f14fa
@SirAionTech @eLBati
[MIG] l10n_it_financial_statements_report: Migration to 16.0
abe9e48
@SirAionTech @eLBati
[REF] l10n_it_financial_statements_report: Remove test output file
8a8ec87
@mymage @eLBati
Translated using Weblate (Italian)
00ee5c4 
Currently translated at 100.0% (70 of 70 strings)

Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_financial_statements_report
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_financial_statements_report/it/
@SirAionTech @eLBati
Updated from template
d79520e
@SirAionTech @eLBati
[REF] l10n_it_financial_statements_report: Update repo template
658a6a8
@SirAionTech @eLBati
[REF] l10n_it_financial_statements_report: Reformatted after template…
b722313 
… update
@SirAionTech @eLBati
Updated from template
3e7da6d
@SirAionTech @eLBati
[FIX] l10n_it_financial_statements_report: Prepayments are assets
14fe443
@FrancescoGermani @eLBati
[FIX]l10n_it_financial_statements_report: Syntax compatibility
65af8a0 
Report XLSX: the syntax "if isinstance(value, int | float)" can be used on Python 3.10 and above versions.
16.0 code should be compatible with Python>=3.7 tho.
@mymage @eLBati
Translated using Weblate (Italian)
f315cf9 
Currently translated at 100.0% (70 of 70 strings)

Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_financial_statements_report
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_financial_statements_report/it/
@eLBati
FIX l10n_it_financial_statements_report: use landscape format for PDF
4cd3b86
@eLBati
Translated using Weblate (Italian)
2fe5ede 
Currently translated at 100.0% (70 of 70 strings)

Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_financial_statements_report
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_financial_statements_report/it/
@primes2h @eLBati
Translated using Weblate (Italian)
e393411 
Currently translated at 100.0% (70 of 70 strings)

Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_financial_statements_report
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_financial_statements_report/it/
@micheledic @eLBati
[FIX] l10n_it_financial_statements_report: fix for KeyError 'grouped_…
a8ed04e 
…key'
@odooNextev @eLBati
[IMP] l10n_it_financial_statements_report: add company header
614191c
@mymage @eLBati
Translated using Weblate (Italian)
5c70738 
Currently translated at 100.0% (71 of 71 strings)

Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_financial_statements_report
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_financial_statements_report/it/
@micheledic @eLBati
[IMP] l10n_it_financial_statements_report: pre-commit stuff
73c269a
@micheledic @eLBati
[MIG] l10n_it_financial_statements_report: Migration to 18.0
a09fef4
@TheMule71 @eLBati
[FIX] l10n_it_financial_statements_report: call super()
b0c9443 
After PR OCA/account-financial-reporting#1408 it's better to use the
provided _prepare_report_data() from the abstract model as it's
pre-populated with needed data.
@TheMule71 @eLBati
[FIX] l10n_it_financial_statements_report: date_range visibility cont…
5eed1a6 
…rolled by its module
@OCA-git-bot OCA-git-bot added series:19.0 mod:l10n_it_financial_statements_report Module l10n_it_financial_statements_report labels Oct 1, 2026
@eLBati eLBati mentioned this pull request Oct 1, 2026
Closed
Borruso
Borruso approved these changes Oct 2, 2026
View reviewed changes

@Borruso Borruso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tafaRU
tafaRU requested changes Oct 5, 2026
View reviewed changes

@tafaRU tafaRU left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho notato solo un piccolo problema nella history: il commit 96b316c è stato integrato nel commit di migrazione. Sarebbe opportuno scorporalo. Grazie.

Per il resto LGMT 👍

@eLBati
[FIX] l10n_it_financial_statements_report: do not require xlrd==1.2.0
3045f17 
xlrd is only used by the tests, and report_xlsx already depends on it.
Odoo checks the version of external dependencies on install and
installs xlrd 2.0.1 on Python >= 3.12, so the pin made the module
uninstallable there.

xlrd 2 cannot read .xlsx files: use openpyxl in the tests, which Odoo
requires on every Python version.

Assisted-by: Claude Opus 5.5
@eLBati
eLBati force-pushed the 19.0-mig-l10n_it_financial_statements_report-lb branch from dda9165 to 3045f17 Compare October 6, 2026 08:47
@eLBati

eLBati commented Oct 6, 2026

Copy link
Copy Markdown
Member Author

@tafaRU grazie, fatto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tafaRU tafaRU tafaRU approved these changes
+1 more reviewer
@Borruso Borruso Borruso approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved mod:l10n_it_financial_statements_report Module l10n_it_financial_statements_report series:19.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.