[FIX][14.0] l10n_it_fiscalcode - handle 'omocodia' #5116
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment. Puoi togliere la versione dal titolo del commit? Attualmente è Il commit deve seguire https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,9 @@ | ||
| **Italiano** | ||
|
|
||
| Installare i moduli Python: `codicefiscale <https://pypi.python.org/pypi/codicefiscale>`__ | ||
| e `python-stdnum <https://pypi.org/project/python-stdnum>`__. | ||
|
|
||
| **English** | ||
|
|
||
| Install the Python packages: `codicefiscale <https://pypi.python.org/pypi/codicefiscale>`__ | ||
| and `python-stdnum <https://pypi.org/project/python-stdnum>`__. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| # Copyright 2024 Simone Rubino - Aion Tech | ||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | ||
|
|
||
|
|
||
| from odoo.exceptions import ValidationError | ||
| from odoo.tests.common import TransactionCase | ||
|
|
@@ -34,6 +33,14 @@ def test_fiscalcode_compute(self): | |
| self.assertEqual(self.partner.fiscalcode, "RSSMRA84H04H501X") | ||
|
|
||
| def test_fiscalcode_check(self): | ||
| # Omocodia | ||
| self.env["res.partner"].create( | ||
| { | ||
| "name": "Person", | ||
| "is_company": False, | ||
| "fiscalcode": "RSSMRA70A01Z50QQ", | ||
|
Contributor
There was a problem hiding this comment. Confermo che con il vecchio metodo questo falliva: >>> from codicefiscale import isvalid
>>> isvalid("RSSMRA70A01Z50QQ")
FalseIl codice non è valido per l'AdE (https://telemanagrafici.agenziaentrate.gov.it/VerificaCF/Scegli.do?parameter=verificaCf) solo perché non esiste, ma come mi hai spiegato la struttura è corretta perché ha una lettera invece di un numero nella penultima posizione |
||
| } | ||
| ) | ||
| # Wrong FC length | ||
| with self.assertRaises(ValidationError): | ||
| self.env["res.partner"].create( | ||
|
|
@@ -90,8 +97,6 @@ def test_fiscal_code_check_change_to_person(self): | |
| } | ||
| ) | ||
| partner.fiscalcode = wrong_person_fiscalcode | ||
|
Contributor
There was a problem hiding this comment. Come mai serve togliere questi |
||
|
|
||
| # Act | ||
| with self.assertRaises(ValidationError) as ve: | ||
|
|
@@ -117,8 +122,6 @@ def test_fiscal_code_check_company_VAT_change_to_person(self): | |
| } | ||
| ) | ||
| partner.fiscalcode = company_vat | ||
|
|
||
| # Act | ||
| with self.assertRaises(ValidationError) as ve: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ elementpath | |
| num2words>=0.5.12 | ||
| openupgradelib | ||
| phonenumbers | ||
| python-stdnum | ||
| unidecode | ||
| xlrd | ||
| xlsxwriter | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Questa libreria è già compresa tra i requirements di Odoo (https://github.com/odoo/odoo/blob/cc0060e889603eb2e47fa44a8a22a70d7d784185/requirements.txt#L55), la puoi rimuovere da qui (e dalle modifiche a
INSTALL) così vediamo se funziona tutto lo stesso?