Skip to content

[17.0][ADD] hr_attendance_resource_calendar - #229

Open
edescalona wants to merge 1 commit into
OCA:17.0from
BinhexTeam:17.0-add-hr_attendance_resource_calendar
Open

edescalona wants to merge 1 commit into
OCA:17.0from
BinhexTeam:17.0-add-hr_attendance_resource_calendar

Conversation

@edescalona

@edescalona edescalona commented Aug 4, 2025 •

Copy link
Copy Markdown

@BinhexTeam

This module allows you to block attendance based on the employee's work schedule.

Allows you to define a time value which allows the employee to check in before the actual time.

@edescalona
edescalona force-pushed the 17.0-add-hr_attendance_resource_calendar branch from 86db289 to 42a6b4b Compare August 4, 2025 14:06
Comment thread hr_attendance_resource_calendar/models/hr_employee.py Outdated
@christian-ramos-tecnativa

Copy link
Copy Markdown

Also I think it would be nice to have a variable value configurable, so the employees are able to log in 10 or 5 minutes before the actual time (or any value set by the user). It could be added in the calendar as a new field.

@edescalona
edescalona force-pushed the 17.0-add-hr_attendance_resource_calendar branch from 42a6b4b to 3655cb6 Compare August 5, 2025 22:27
@edescalona

Copy link
Copy Markdown
Author

Hi @Christian-RB ready for review

@edescalona
edescalona marked this pull request as ready for review August 5, 2025 22:32
@christian-ramos-tecnativa

Copy link
Copy Markdown

@edescalona Why is the restriction only applied to the first check-in of the day?
In my opinion, it should apply to every entry. Otherwise, what will likely happen is that all employees will finish lunch and then queue up to check in at the same time, meaning the last person in line will end up checking in too late, even if they returned on time. Let me know is I explain my self properly. Thanks!

@christian-ramos-tecnativa

Copy link
Copy Markdown

Also, to ensure the tests pass, you should add a configurable setting on the calendar or res.config.settings so the original workflow works as usual.

@edescalona
edescalona force-pushed the 17.0-add-hr_attendance_resource_calendar branch from 3655cb6 to e9ca65a Compare August 6, 2025 15:03
@edescalona

Copy link
Copy Markdown
Author

Hi @Christian-RB thanks for your comments, let me know when you can.

@github-actions

github-actions Bot commented Dec 7, 2025

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 7, 2025
@github-actions github-actions Bot closed this Oct 4, 2026
@edescalona

Copy link
Copy Markdown
Author

Hi @pedrobaeza @jelenapoblet , could you open this PR? Thanks.

@jelenapoblet jelenapoblet reopened this Oct 21, 2026
@OCA-git-bot OCA-git-bot added series:17.0 mod:hr_attendance_resource_calendar Module hr_attendance_resource_calendar labels Oct 21, 2026
@jelenapoblet

Copy link
Copy Markdown

done!

@edescalona
edescalona force-pushed the 17.0-add-hr_attendance_resource_calendar branch from e9ca65a to fb308d1 Compare October 21, 2026 17:48
@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:hr_attendance_resource_calendar Module hr_attendance_resource_calendar series:17.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants