[IMP] fieldservice_timeline: New Menu to Show Orders by Latest Request#1516
[IMP] fieldservice_timeline: New Menu to Show Orders by Latest Request#1516
Conversation
|
|
quirino95
left a comment
There was a problem hiding this comment.
Code and functional review: LGTM!
HekkiMelody
left a comment
There was a problem hiding this comment.
Code review, LGTM
As an aside, I don't find "Latest Request Date" to be particularly effective as a field descriptor (I know it's the term already used as the string of request_late, and it was correct to be consistent with it)
From my understanding it represent the latest possible date by which the fsm.order must be fulfilled and closed, so maybe something like "Due by" or "To close before" or something similar would be clearer and less ambiguous. (On the other hand, "Latest Request Date" sounds like it would show when the latest fsm.order for the same partner was opened)
|
The other test failure is due to openstreetmaps rate limiting the tests https://github.com/OCA/field-service/actions/runs/22137338801/job/63992330395?pr=1516#step:8:229 A similar fix has been proposed in the geospatial repository: OCA/geospatial@d125f93 We could copy it here as well |
aa49bc3 to
21da28f
Compare
This time the error isn't there, but I fixed it anyway in #1519, thanks for the hint! |
21da28f to
862fc25
Compare
Depends on: