Skip to content

[IMP] fieldservice_timeline: New Menu to Show Orders by Latest Request#1516

Open
SirPyTech wants to merge 1 commit intoOCA:16.0from
PyTech-SRL:16.0-imp-fieldservice_timeline-use_request_late
Open

[IMP] fieldservice_timeline: New Menu to Show Orders by Latest Request#1516
SirPyTech wants to merge 1 commit intoOCA:16.0from
PyTech-SRL:16.0-imp-fieldservice_timeline-use_request_late

Conversation

@SirPyTech
Copy link
Copy Markdown
Contributor

@SirPyTech SirPyTech commented Feb 18, 2026

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hi @max3903, @wolfhall,
some modules you are maintaining are being modified, check this out!

@SirPyTech
Copy link
Copy Markdown
Contributor Author

pre-commit check fails because of the error mentioned in OCA/oca-addons-repo-template#333, the fix has been included in #1517.

Copy link
Copy Markdown
Contributor

@quirino95 quirino95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review: LGTM!

Copy link
Copy Markdown
Contributor

@HekkiMelody HekkiMelody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

As an aside, I don't find "Latest Request Date" to be particularly effective as a field descriptor (I know it's the term already used as the string of request_late, and it was correct to be consistent with it)

From my understanding it represent the latest possible date by which the fsm.order must be fulfilled and closed, so maybe something like "Due by" or "To close before" or something similar would be clearer and less ambiguous. (On the other hand, "Latest Request Date" sounds like it would show when the latest fsm.order for the same partner was opened)

@HekkiMelody
Copy link
Copy Markdown
Contributor

HekkiMelody commented Feb 23, 2026

The other test failure is due to openstreetmaps rate limiting the tests

https://github.com/OCA/field-service/actions/runs/22137338801/job/63992330395?pr=1516#step:8:229

A similar fix has been proposed in the geospatial repository: OCA/geospatial@d125f93

We could copy it here as well

@SirPyTech
Copy link
Copy Markdown
Contributor Author

The other test failure is due to openstreetmaps rate limiting the tests

https://github.com/OCA/field-service/actions/runs/22137338801/job/63992330395?pr=1516#step:8:229

A similar fix has been proposted in the geospatial repository: OCA/geospatial@d125f93

We could copy it here as well

This time the error isn't there, but I fixed it anyway in #1519, thanks for the hint!

marcos-mendez

This comment was marked as low quality.

@SirPyTech SirPyTech force-pushed the 16.0-imp-fieldservice_timeline-use_request_late branch from 21da28f to 862fc25 Compare March 16, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants