Skip to content

[17.0] [IMP] fieldservice_account_analytic: use python contrains instead of validation at creation for analytic lines #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rrebollo wants to merge 1 commit into
base: 17.0
Choose a base branch
from
+13 −9
Open

[17.0] [IMP] fieldservice_account_analytic: use python contrains instead of validation at creation for analytic lines #1514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions fieldservice_account_analytic/models/analytic_account.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,21 @@ class AccountAnalyticLine(models.Model):
fsm_order_id = fields.Many2one("fsm.order", string="FSM Order")
product_id = fields.Many2one("product.product", string="Time Type")

@api.model
def create(self, vals):
order = self.env["fsm.order"].browse(vals.get("fsm_order_id"))
if order:
if order.location_id.analytic_account_id:
vals["account_id"] = order.location_id.analytic_account_id.id
else:
@api.constrains("fsm_order_id")
def _check_fsm_order_id(self):
for line in self:
if (
line.fsm_order_id
and not line.fsm_order_id.location_id.analytic_account_id
):
raise ValidationError(
_("No analytic account set " "on the order's Location.")
_(
"No analytic account set on the order's Location "
"%(location_name)s. Please set an analytic account on the "
"Location before creating an analytic line for this order.",
location_name=line.fsm_order_id.location_id.name,
)
)
return super().create(vals)

@api.onchange("product_id")
def onchange_product_id(self):
Expand Down
Loading