Skip to content

[17.0] [IMP] fieldservice_recurring: optimize order generation logic #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brian10048 wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[17.0] [IMP] fieldservice_recurring: optimize order generation logic #1487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions fieldservice_recurring/models/fsm_recurring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,15 +219,13 @@ def _generate_orders(self):
"""
orders = self.env["fsm.order"]
for rec in self:
order_dates = []
for order in rec.fsm_order_ids:
if order.scheduled_date_start:
order_dates.append(order.scheduled_date_start.date())
max_orders = rec.max_orders if rec.max_orders > 0 else False
order_count = rec.fsm_order_count
for date in rec._get_rruleset():
if date.date() in order_dates:
continue
dates = list(rec._get_rruleset())
if order_count > 0:
# skip first date since an order already exists for that date
dates = dates[1:]
for date in dates:
if max_orders > order_count or not max_orders:
orders |= rec._create_order(date=date)
order_count += 1
Expand Down