Repository navigation
Conversation
In v16, the setting group_stock_production_lot is linked to internal and portal users (group="base.group_user,base.group_portal"), but in v15 it was only linked to internal users. As the setting is only True when all the groups imply stock.group_production_lot, it appears disabled after the migration. Add the implied group to portal users when it was enabled.
OCA-git-bot
added
mod:openupgrade_scripts
Member
|
Isn't this the same as #5926 ? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v16, the setting
group_stock_production_lotis linked to internal and portal users (group="base.group_user,base.group_portal"; see https://github.com/odoo/odoo/blob/e46fb655deed825c8a3557cb7080839daedb2dfe/addons/stock/models/res_config_settings.py#L14), but in v15 it was only linked to internal users. As the setting is only True when all the groups implystock.group_production_lot, it appears disabled after the migration. Add the implied group to portal users when it was enabled.Steps to reproduce:
In a v15 database, install the
stockmodule and enable the Lots & Serial Numbers setting:Migrate the database and go to Settings: the Lots & Serial Numbers setting is disabled.
The users aren't removed from the group, but having this setting disabled has some implications. For example in V18, after the migration, if you have the
product_expirymodule installed, it can be uninstalled when you save the settings. See: https://github.com/odoo/odoo/blob/4d8930a92605ee724a15e26805ff5266d56964cf/addons/stock/models/res_config_settings.py#L65In a fresh database created in v16, you can see that the
Portalgroup has the inherited group Manage Lots / Serial Numbers:But before this commit, the
Portalgroup doesn't have the inherited group:@pedrobaeza @hbrunn @MiquelRForgeFlow could you please review this?