libbladeRF: unlock the device mutex on the 8-bit format error path - #1073
Open
wormuz wants to merge 1 commit into
Open
libbladeRF: unlock the device mutex on the 8-bit format error path#1073wormuz wants to merge 1 commit into
wormuz wants to merge 1 commit into
Conversation
|
|
bladerf_sync_config() and bladerf_init_stream() take dev->lock, then return BLADERF_ERR_UNSUPPORTED without releasing it when an SC8_Q7 format is requested on a bladeRF1. The device is left locked, so every subsequent API call on that handle blocks forever. The caller sees a hang rather than the error that was actually returned. Found while auditing 2.6.0 changes; both call sites are in bladerf.c.
|
Good evening
Nuand/bladeRF
Be Advised you all stolen this from Yusuf Ali which is I ..you claim the
formant you just mention My name and it ok for you to profit of it with out
my consent I'll be dam if I would ever go threw any of you theving ass site
to build anything and then you won't to use Apache law to do it. as
American Indian Apache means (enemy ) I can give a damn if it don't never
work .
Yusuf Ali
470 493 0900
…On Mon, Aug 17, 2026, 8:36 PM CLAassistant ***@***.***> wrote:
*CLAassistant* left a comment (Nuand/bladeRF#1073)
<#1073 (comment)>
[image: CLA assistant check]
<https://cla-assistant.io/Nuand/bladeRF?pullRequest=1073>
Thank you for your submission! We really appreciate it. Like many open
source projects, we ask that you sign our Contributor License Agreement
<https://cla-assistant.io/Nuand/bladeRF?pullRequest=1073> before we can
accept your contribution.
You have signed the CLA already but the status is still pending? Let us
recheck <https://cla-assistant.io/check/Nuand/bladeRF?pullRequest=1073>
it.
—
Reply to this email directly, view it on GitHub
<#1073?email_source=notifications&email_token=BDZCWWF6KCBBSQVXQHORMG35KOQKLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMZSGE4TKOBZGY4KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#issuecomment-5321958968>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDZCWWBI5JFNSFI34UYJSYT5KOQKLAVCNFSNUABDKJSXA33TNF2G64TZHM4DEOBTGA4DKO2JONZXKZJ3GUYTONRXGYYDQNJWUF3AE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bladerf_sync_config() and bladerf_init_stream() take dev->lock, then return BLADERF_ERR_UNSUPPORTED without releasing it when an SC8_Q7 format is requested on a bladeRF1.
The device is left locked, so every subsequent API call on that handle blocks forever. The caller sees a hang rather than the error that was actually returned.
Both call sites are in
bladerf.c; the fix adds the missingMUTEX_UNLOCKbefore each early return.Found while auditing the 2.6.0 changes against a bladeRF 2.0 micro xA4.