Repository navigation
chore(deps-dev): upgrade to SvelteKit 3 - #21
Merged
Merged
Conversation
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Dependencies (plus one small fix kit 3 forced on me)
Overview
Kit 3 and adapter-node 6 each need the other, so Dependabot's two PRs could never install on their own. This moves both over in one go, with what the migrator does (
#libimports, tsconfig extending$app/tsconfig,gotowithshallowin place ofreplaceState), and thecookieoverride's gone too since it was holding kit 3 back on cookie 0.7.One thing the migrator doesn't catch: kit 3 now checks the origin on a POST with no content type, and adapter-node assumes its own origin is
https. So on plain http (npx, Docker,127.0.0.1) the rescan button got a 403. Both POSTs from the page now go out as JSON like the settings one already did, which kit leaves to the browser's CORS rules.Issue Number
Replaces #19 and #20
Additional Info
Clicked through builds of this and main in Chromium over http. Changing the range updates the URL without a reload on both, settings save fine, and rescan is a 200 here (and a 403 if I put the old fetch back).
Some AI was use when making this