Repository navigation
fix: retain model names containing interval-like text in evaluation - #312
Closed
student-shivamm wants to merge 1 commit into
Closed
student-shivamm wants to merge 1 commit into
student-shivamm wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #311
When
modelsis omitted,evaluatetreatsmodel-hi-2025-v2as an interval column and silently omits its score. Explicit model selection returns the expected score. Anchor interval matching to the numeric suffix so interval-like text inside model names is retained, while integer, fractional and scientific-notation interval columns remain excluded.Regression tests compare inferred and explicit selection in pandas and Polars and assert known MAE values. The same 24-case matrix has 16 failures and 8 passing controls on upstream, and passes with the patch.
Validation: evaluation/loss suites plus regression module: 190 passed, one skipped (upstream Windows distributed-test restriction). Separate data/validation/processing plus regression run: 399 passed, ten skipped. All configured pinned pre-commit hooks pass on the changed files. Direct no-incremental mypy with runtime dependencies reports the same 73 existing errors on upstream and the candidate; the isolated configured hook passes. No cross-platform or distributed CI result is claimed.
AI assistance was used for investigation, implementation and validation. The reproduction and recorded local results were checked; acceptance remains the maintainers' decision.