Repository navigation
fix: support string, date, and datetime bounds in polars fill_gaps - #302
Open
Jakub Krasuski (Blizzeq) wants to merge 1 commit into
Open
Jakub Krasuski (Blizzeq) wants to merge 1 commit into
Jakub Krasuski (Blizzeq) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
fill_gapson a Polars DataFrame with a customstartorendtimestamp (such as a string like'2020-01-01', adate, or adatetime),_determine_bound_plcreated aSeries([val])without matching the target dtype of the time column. This caused a panic indatetime_rangeswhen passed string series, or a schema error when joining differing datetime and date keys.This PR ensures
_determine_bound_plconverts scalar bounds (strings, dates, datetimes) to match the time column's target dtype in Polars before building the grid. Added regression tests covering string, date, and datetime bounds on Polars.