Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions tests/test_feature_engineering.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,3 +179,26 @@ def test_pipeline(setup_series, freq, setup_pipeline, setup_features):
future_df.drop(columns="unique_id"),
check_dtype=False,
)


@pytest.mark.parametrize("engine", ["pandas", "polars"])
def test_pipeline_no_horizon(setup_series, setup_features, engine):
# with h=0 there are no future values, but every feature must be computed
series, series_pl = setup_series
individual_results = [f(series, freq="D", h=0) for f in setup_features]
expected = reduce_join(
[r[0] for r in individual_results], on=["unique_id", "ds", "y"]
)
if engine == "pandas":
transformed, future = pipeline(series, features=setup_features, freq="D", h=0)
else:
transformed, future = pipeline(
series_pl, features=setup_features, freq="1d", h=0
)
transformed = transformed.to_pandas()
pd.testing.assert_frame_equal(
transformed.drop(columns="unique_id"),
expected.drop(columns="unique_id"),
check_dtype=False,
)
assert future.shape == (0, 0)
4 changes: 4 additions & 0 deletions utilsforecast/feature_engineering.py
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,10 @@ def pipeline(
if transformed is None:
transformed = f_transformed
future = f_future
elif h == 0:
# the future dataframe is empty, so the features are the new columns
feat_cols = [c for c in f_transformed.columns if c not in df.columns]
transformed = ufp.horizontal_concat([transformed, f_transformed[feat_cols]])
else:
feat_cols = [c for c in f_future.columns if c not in (id_col, time_col)]
transformed = ufp.horizontal_concat([transformed, f_transformed[feat_cols]])
Expand Down
Loading