Repository navigation
small change for nb if inf value plus adding linex in __all__ on top - #188
Merged
Merged
Conversation
Saul (nasaul)
requested changes
Oct 6, 2025
Saul (nasaul)
left a comment
Saul (nasaul)
left a comment
Contributor
There was a problem hiding this comment.
Remove printing and use warnings.warn
Saul (nasaul)
enabled auto-merge (squash)
October 9, 2025 00:14
Saul (nasaul)
disabled auto-merge
November 7, 2025 00:51
Saul (nasaul)
enabled auto-merge (squash)
November 7, 2025 01:39
Saul (nasaul)
self-requested a review
November 7, 2025 01:42
Saul (nasaul)
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves issue #187.
The solution proposed here gives the user the opportunity to choose between the standard way of calculation, which could result in inf, or to also re-write inf values to 0 (on top of just using fillna(0)).
Also linex was added to all on losses.py, because this was missing from last PR.