Repository navigation
fix: keep all the features in pipeline when h is 0 - #291
Merged
Mariana Menchero García (MMenchero) merged 2 commits intoOct 5, 2026
Merged
Mariana Menchero García (MMenchero) merged 2 commits into
Mariana Menchero García (MMenchero) merged 2 commits into
Conversation
Contributor
|
Thank you for your contribution Jakub Krasuski (@Blizzeq). |
Mariana Menchero García (MMenchero)
approved these changes
Oct 5, 2026
Mariana Menchero García (MMenchero)
merged commit Oct 5, 2026
64708bd
into
Nixtla:main
17 of 18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pipelinetook the feature column names from each function's future dataframe, which is empty whenh=0(the default). On pandas that silently dropped every feature after the first one, and on polars it raisedDuplicateError, because selecting an empty list of columns returns all of them. Forh=0I now take the names from the columns the function added to the input, and leave theh > 0path as it was. Added a test that runs the pipeline withh=0on pandas and polars and compares it with the features computed one by one.