Repository navigation
ci: consolidate tests in pytest workflow and drop nightly wheels - #1282
Open
José Morales (jmoralez) wants to merge 4 commits into
Open
José Morales (jmoralez) wants to merge 4 commits into
José Morales (jmoralez) wants to merge 4 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # .github/workflows/ci.yaml # .github/workflows/python-publish.yml # .github/workflows/test-publish.yml
There was a problem hiding this comment.
🟢 Approval recommended
The workflow migration and related cleanup are consistent, with no unresolved blocking issues identified.
0 open findings
What changed in this PR
Consolidates wheel and distributed testing in pytest.yaml, removes nightly wheel publishing, and enables native Linux ARM builds.
Changes:
- Adds five-platform wheel tests and Linux distributed tests.
- Removes obsolete CI jobs, nightly publishing, and installation instructions.
- Uses native ARM runners and accommodates platform-dependent ARIMA trace output.
| File | Description |
|---|---|
tests/test_arima.py |
Normalizes one platform-sensitive trace score. |
nbs/docs/getting-started/installation.ipynb |
Removes nightly installation instructions. |
action_files/update_index.py |
Deletes the nightly wheel index helper. |
.github/workflows/test-publish.yml |
Switches ARM builds from QEMU to native runners. |
.github/workflows/python-publish.yml |
Switches release ARM builds to native runners. |
.github/workflows/pytest.yaml |
Adds wheel and distributed test jobs. |
.github/workflows/ci.yaml |
Removes the old test matrix and nightly publishing. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
run-testsmatrix fromci.yaml. Its 25 macOS/Windows jobs have been no-ops since New documentation pipeline #1037 removed their build/test step; they pass in ~20s without doing anything.publish-nightly-wheels,action_files/update_index.pyand the nightly install instructions. The bucket returns 403 to anonymous users, so the wheels aren't downloadable, and they were Linux-only and versioned identically to the latest release.wheel-testsjob topytest.yaml: builds a cp310 wheel per platform (Linux x86_64, Linux aarch64, Windows, macOS x86_64, macOS arm64) with cibuildwheel and runstests/(minus the distributed tests) against the installed wheel, with thedevtest dependencies taken fromuv.lock.distributed-testsjob topytest.yamlthat runs theaction_filesdask/spark/ray tests previously run byci.yaml.ubuntu-24.04-armrunners instead of QEMU emulation, in the new job and in the publish workflows.test_issue_649, replace the first candidate's score with a placeholder before comparing the trace. Its AR/MA roots sit on the 1.01 rejection threshold, so it printsinfon x86_64, macOS and Windows but a finite score on Linux aarch64, which now runs the suite.Why
All test checks now live in
pytest.yaml, and every check that runs does real work. Wheels are tested again on every platform (they haven't been outside Linux since the move from notebooks to pytest), and Linux aarch64 runs the test suite for the first time.