Repository navigation
fix: report short series in cross_validation for polars inputs - #1273
Open
Moury Bachina (MouryB) wants to merge 1 commit into
Open
Moury Bachina (MouryB) wants to merge 1 commit into
Moury Bachina (MouryB) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1272
Summary
When
cross_validationfinds series that are too short for the requested windows, it builds the error message withself.uids[short_series]. That boolean-mask__getitem__works for pandas but raisesTypeError: selecting rows by passing a boolean mask to __getitem__ is not supportedfor polars, which hides the intendedValueError.The mask is now applied with
utilsforecast.processing.filter_with_mask, whichcore.pyalready uses (viaufp) to handle pandas and polars the same way. Behavior for pandas is unchanged.Tests
Added
test_cross_validation_short_series_message, parametrized over pandas and polars, with two short series so the message lists more than one id. The polars case fails on the currentmainand passes with this change; the pandas case passes on both.Note
This PR was written with an AI coding assistant (Claude Code).