Repository navigation
fix: preserve fitted order of future exogenous columns - #1270
Anton Soloviev (antonsoo) wants to merge 1 commit into
Conversation
|
|
1 similar comment
|
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Select future covariate columns in the stored training order before converting
X_dfinto a grouped array. The existing shape and required-name checks stay in place.Currently the required features are checked by name but passed to the model in the incoming dataframe order. Reordering two named columns silently exchanges their fitted coefficients:
This fails on current main, with a maximum prediction difference of about 2,654 passengers, and passes with this change.
Validation:
forecast,fit_predict, andfit().predict(), pandas/Polars, and one/two workers.The real-data checks establish covariate alignment, not improved forecast accuracy. Distributed Spark/Dask/Ray execution was not exercised.