Repository navigation
chore: remove numba leftovers - #1268
Open
José Morales (jmoralez) wants to merge 2 commits into
Open
José Morales (jmoralez) wants to merge 2 commits into
José Morales (jmoralez) wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
🟡 Changes recommended
The documentation edit leaves visible merge-conflict marker cells surrounding the removed callout.
1 open finding
What changed in this PR
Removes obsolete Numba references following the C++ migration in #1099.
Changes:
- Removes the unused Numba cache environment variable.
- Removes outdated JIT compilation guidance.
| File | Description |
|---|---|
.github/workflows/ci.yaml |
Removes obsolete CI configuration. |
nbs/docs/getting-started/getting_Started_complete.ipynb |
Removes outdated Numba guidance. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numba was removed in #1099, but two references to it remained:
NIXTLA_NUMBA_CACHEenv var from the CI workflow, since nothing reads it anymore.🤖 Generated with Claude Code