Repository navigation
fix: preserve fitted order of future exogenous columns - #1270
Merged
José Morales (jmoralez) merged 2 commits intoOct 12, 2026
Merged
Conversation
|
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
José Morales (jmoralez)
requested changes
Oct 12, 2026
José Morales (jmoralez)
approved these changes
Oct 12, 2026
José Morales (jmoralez)
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Can you please sign the CLA? Once that's done this'll be ready to be merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Select future covariate columns in the stored training order before converting
X_dfinto a grouped array. The existing shape and required-name checks stay in place.Currently the required features are checked by name but passed to the model in the incoming dataframe order. Reordering two named columns silently exchanges their fitted coefficients:
This fails on current main, with a maximum prediction difference of about 2,654 passengers, and passes with this change.
Validation:
forecast,fit_predict, andfit().predict(), pandas/Polars, and one/two workers.The real-data checks establish covariate alignment, not improved forecast accuracy. Distributed Spark/Dask/Ray execution was not exercised.