Skip to content

pyjwkest: remove 'future' dependency to fix build#466877

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
stapelberg:pyjwkest
Dec 3, 2025
Merged

pyjwkest: remove 'future' dependency to fix build#466877
Aleksanaa merged 1 commit intoNixOS:masterfrom
stapelberg:pyjwkest

Conversation

@stapelberg
Copy link
Copy Markdown
Contributor

This dependency is unused in pyjwkest, but disabled in nixpkgs. There is an upstream pull request pending to remove the dependency: IdentityPython/pyjwkest#107

Before this change, these 2 Python packages failed to build:

nix build .#python313Packages.pyjwkest
nix build .#python313Packages.oic

With the following message:

error:
       … while evaluating the attribute 'drvPath'
         at /nix/store/65sypvf1f26fyi1vq6h25wg9z5gipgy8-source/lib/customisation.nix:429:7:
          428|     // {
          429|       drvPath =
             |       ^
          430|         assert condition;

       … while evaluating the attribute 'drvPath'
         at /nix/store/65sypvf1f26fyi1vq6h25wg9z5gipgy8-source/lib/customisation.nix:429:7:
          428|     // {
          429|       drvPath =
             |       ^
          430|         assert condition;

       … while calling the 'derivationStrict' builtin
         at <nix/derivation-internal.nix>:37:12:
           36|
           37|   strict = derivationStrict drvAttrs;
             |            ^
           38|

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: future-1.0.0 not supported for interpreter python3.13

(I am using the oic package via the pretix-oidc plugin.)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@stapelberg
Copy link
Copy Markdown
Contributor Author

nixpkgs-review said:

% NIX_PATH=nixpkgs=channel:nixos-25.11 nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
From https://github.com/NixOS/nixpkgs
 * [new branch]                master     -> refs/nixpkgs-review/0
$ git worktree add /home/michael/.cache/nixpkgs-review/rev-23044e19cbc0bdcb8807d91de5ff3dd5c3aa6660/nixpkgs bd98643a3d635d6aa945af300c5742d1a6539dc0
Preparing worktree (detached HEAD bd98643a3d63)
HEAD is now at bd98643a3d63 python3Packages.warp-lang: 1.9.1 -> 1.10.0 (#462195)
Local evaluation for computing rebuilds
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/michael/.cache/nixpkgs-review/rev-23044e19cbc0bdcb8807d91de5ff3dd5c3aa6660/nixpkgs nixpkgs-overlays=/tmp/nix-shell-2310325-4068853187/tmp2dhnzrkn -qaP --xml --out-path --show-trace --no-allow-import-from-derivation
$ git merge --no-commit --no-ff 23044e19cbc0bdcb8807d91de5ff3dd5c3aa6660
Automatic merge went well; stopped before committing as requested
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/michael/.cache/nixpkgs-review/rev-23044e19cbc0bdcb8807d91de5ff3dd5c3aa6660/nixpkgs nixpkgs-overlays=/tmp/nix-shell-2310325-4068853187/tmp2dhnzrkn -qaP --xml --out-path --show-trace --no-allow-import-from-derivation --meta
--------- Impacted packages on 'x86_64-linux' ---------
2 packages added:
python313Packages.oic (init at 1.7.0) python313Packages.pyjwkest (init at 1.4.2)

4 packages updated:
python3.12-oic python3.12-pyjwkest python3.12-rucio rucio


$ nix build --file /nix/store/ihslwbxj0y8jv0730zn2qna5vjn90pl3-nixpkgs-review-3.5.1/lib/python3.13/site-packages/nixpkgs_review/nix/review-shell.nix --nix-path 'nixpkgs=/home/michael/.cache/nixpkgs-review/rev-23044e19cbc0bdcb8807d91de5ff3dd5c3aa6660/nixpkgs nixpkgs-overlays=/tmp/nix-shell-2310325-4068853187/tmp2dhnzrkn' --extra-experimental-features 'nix-command no-url-literals' --no-link --keep-going --no-allow-import-from-derivation --option build-use-sandbox relaxed --argstr local-system x86_64-linux --argstr nixpkgs-path /home/michael/.cache/nixpkgs-review/rev-23044e19cbc0bdcb8807d91de5ff3dd5c3aa6660/nixpkgs --argstr nixpkgs-config-path /tmp/nix-shell-2310325-4068853187/tmpypi0l42v.nix --argstr attrs-path /home/michael/.cache/nixpkgs-review/rev-23044e19cbc0bdcb8807d91de5ff3dd5c3aa6660/attrs.nix
--------- Report for 'x86_64-linux' ---------
10 packages built:
python312Packages.oic python312Packages.oic.dist python312Packages.pyjwkest python312Packages.pyjwkest.dist rucio rucio.dist python313Packages.oic python313Packages.oic.dist python313Packages.pyjwkest python313Packages.pyjwkest.dist

Logs can be found under:
/home/michael/.cache/nixpkgs-review/rev-23044e19cbc0bdcb8807d91de5ff3dd5c3aa6660/logs


$ /nix/store/n5s95aq6my065mxv8nywdp24afqmk48q-nix-2.31.2/bin/nix-shell --argstr local-system x86_64-linux --argstr nixpkgs-path /home/michael/.cache/nixpkgs-review/rev-23044e19cbc0bdcb8807d91de5ff3dd5c3aa6660/nixpkgs --argstr nixpkgs-config-path /tmp/nix-shell-2310325-4068853187/tmpypi0l42v.nix --argstr attrs-path /home/michael/.cache/nixpkgs-review/rev-23044e19cbc0bdcb8807d91de5ff3dd5c3aa6660/attrs.nix --nix-path 'nixpkgs=/home/michael/.cache/nixpkgs-review/rev-23044e19cbc0bdcb8807d91de5ff3dd5c3aa6660/nixpkgs nixpkgs-overlays=/tmp/nix-shell-2310325-4068853187/tmp2dhnzrkn' /nix/store/ihslwbxj0y8jv0730zn2qna5vjn90pl3-nixpkgs-review-3.5.1/lib/python3.13/site-packages/nixpkgs_review/nix/review-shell.nix

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 6.topic: python Python is a high-level, general-purpose programming language. labels Dec 1, 2025
Comment thread pkgs/development/python-modules/pyjwkest/default.nix
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Dec 2, 2025
Comment thread pkgs/development/python-modules/pyjwkest/default.nix Outdated
This dependency is unused in pyjwkest, but disabled in nixpkgs.
There is an upstream pull request pending to remove the dependency:
IdentityPython/pyjwkest#107

Before this change, these 2 Python packages failed to build:

nix build .#python313Packages.pyjwkest
nix build .#python313Packages.oic

With the following message:

error:
       … while evaluating the attribute 'drvPath'
         at /nix/store/65sypvf1f26fyi1vq6h25wg9z5gipgy8-source/lib/customisation.nix:429:7:
          428|     // {
          429|       drvPath =
             |       ^
          430|         assert condition;

       … while evaluating the attribute 'drvPath'
         at /nix/store/65sypvf1f26fyi1vq6h25wg9z5gipgy8-source/lib/customisation.nix:429:7:
          428|     // {
          429|       drvPath =
             |       ^
          430|         assert condition;

       … while calling the 'derivationStrict' builtin
         at <nix/derivation-internal.nix>:37:12:
           36|
           37|   strict = derivationStrict drvAttrs;
             |            ^
           38|

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: future-1.0.0 not supported for interpreter python3.13

(I am using the oic package via the pretix-oidc plugin.)
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 2, 2025
@stapelberg
Copy link
Copy Markdown
Contributor Author

nixpkgs-review output for the updated PR:

NIX_PATH=nixpkgs=channel:nixos-25.11 nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
$ git worktree add /home/michael/.cache/nixpkgs-review/rev-dbefe89d9e3c8cad3d417754bbb819963f97be99/nixpkgs b4f59db7583ec331051831a679eda8f3b5c62c24
Preparing worktree (detached HEAD b4f59db7583e)
HEAD is now at b4f59db7583e dependabot-cli: 1.78.1 -> 1.79.0 (#467075)
Local evaluation for computing rebuilds
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/michael/.cache/nixpkgs-review/rev-dbefe89d9e3c8cad3d417754bbb819963f97be99/nixpkgs nixpkgs-overlays=/tmp/nix-shell-2581069-2185922591/tmpq1hi5t6n -qaP --xml --out-path --show-trace --no-allow-import-from-derivation
$ git merge --no-commit --no-ff dbefe89d9e3c8cad3d417754bbb819963f97be99
Automatic merge went well; stopped before committing as requested
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/michael/.cache/nixpkgs-review/rev-dbefe89d9e3c8cad3d417754bbb819963f97be99/nixpkgs nixpkgs-overlays=/tmp/nix-shell-2581069-2185922591/tmpq1hi5t6n -qaP --xml --out-path --show-trace --no-allow-import-from-derivation --meta
--------- Impacted packages on 'x86_64-linux' ---------
2 packages added:
python313Packages.oic (init at 1.7.0) python313Packages.pyjwkest (init at 1.4.4)

4 packages updated:
python3.12-oic python312Packages.pyjwkest (1.4.2 → 1.4.4) python3.12-rucio rucio


$ nix build --file /nix/store/ihslwbxj0y8jv0730zn2qna5vjn90pl3-nixpkgs-review-3.5.1/lib/python3.13/site-packages/nixpkgs_review/nix/review-shell.nix --nix-path 'nixpkgs=/home/michael/.cache/nixpkgs-review/rev-dbefe89d9e3c8cad3d417754bbb819963f97be99/nixpkgs nixpkgs-overlays=/tmp/nix-shell-2581069-2185922591/tmpq1hi5t6n' --extra-experimental-features 'nix-command no-url-literals' --no-link --keep-going --no-allow-import-from-derivation --option build-use-sandbox relaxed --argstr local-system x86_64-linux --argstr nixpkgs-path /home/michael/.cache/nixpkgs-review/rev-dbefe89d9e3c8cad3d417754bbb819963f97be99/nixpkgs --argstr nixpkgs-config-path /tmp/nix-shell-2581069-2185922591/tmpw441wr3k.nix --argstr attrs-path /home/michael/.cache/nixpkgs-review/rev-dbefe89d9e3c8cad3d417754bbb819963f97be99/attrs.nix
--------- Report for 'x86_64-linux' ---------
10 packages built:
python312Packages.oic python312Packages.oic.dist python312Packages.pyjwkest python312Packages.pyjwkest.dist rucio rucio.dist python313Packages.oic python313Packages.oic.dist python313Packages.pyjwkest python313Packages.pyjwkest.dist

Logs can be found under:
/home/michael/.cache/nixpkgs-review/rev-dbefe89d9e3c8cad3d417754bbb819963f97be99/logs


$ /nix/store/n5s95aq6my065mxv8nywdp24afqmk48q-nix-2.31.2/bin/nix-shell --argstr local-system x86_64-linux --argstr nixpkgs-path /home/michael/.cache/nixpkgs-review/rev-dbefe89d9e3c8cad3d417754bbb819963f97be99/nixpkgs --argstr nixpkgs-config-path /tmp/nix-shell-2581069-2185922591/tmpw441wr3k.nix --argstr attrs-path /home/michael/.cache/nixpkgs-review/rev-dbefe89d9e3c8cad3d417754bbb819963f97be99/attrs.nix --nix-path 'nixpkgs=/home/michael/.cache/nixpkgs-review/rev-dbefe89d9e3c8cad3d417754bbb819963f97be99/nixpkgs nixpkgs-overlays=/tmp/nix-shell-2581069-2185922591/tmpq1hi5t6n' /nix/store/ihslwbxj0y8jv0730zn2qna5vjn90pl3-nixpkgs-review-3.5.1/lib/python3.13/site-packages/nixpkgs_review/nix/review-shell.nix

[nix-shell:~/.cache/nixpkgs-review/rev-dbefe89d9e3c8cad3d417754bbb819963f97be99]$ 
exit
$ git worktree remove -f /home/michael/.cache/nixpkgs-review/rev-dbefe89d9e3c8cad3d417754bbb819963f97be99/nixpkgs
NIX_PATH=nixpkgs=channel:nixos-25.11 nix-shell -p nixpkgs-review --run   259,03s user 11,96s system 122% cpu 3:40,73 total

@Aleksanaa
Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 466877
Commit: dbefe89d9e3c8cad3d417754bbb819963f97be99 (subsequent changes)
Merge: 27898ea8d9ab1997637dba64b2c98b58c236ed9c

Logs: https://github.com/Aleksanaa/nixpkgs-review-gha/actions/runs/19866779199


x86_64-linux

✅ 10 packages built:
  • python312Packages.oic
  • python312Packages.oic.dist
  • python312Packages.pyjwkest
  • python312Packages.pyjwkest.dist
  • rucio (python312Packages.rucio)
  • rucio.dist (python312Packages.rucio.dist)
  • python313Packages.oic
  • python313Packages.oic.dist
  • python313Packages.pyjwkest
  • python313Packages.pyjwkest.dist

aarch64-linux

✅ 10 packages built:
  • python312Packages.oic
  • python312Packages.oic.dist
  • python312Packages.pyjwkest
  • python312Packages.pyjwkest.dist
  • rucio (python312Packages.rucio)
  • rucio.dist (python312Packages.rucio.dist)
  • python313Packages.oic
  • python313Packages.oic.dist
  • python313Packages.pyjwkest
  • python313Packages.pyjwkest.dist

x86_64-darwin (sandbox = false)

✅ 10 packages built:
  • python312Packages.oic
  • python312Packages.oic.dist
  • python312Packages.pyjwkest
  • python312Packages.pyjwkest.dist
  • rucio (python312Packages.rucio)
  • rucio.dist (python312Packages.rucio.dist)
  • python313Packages.oic
  • python313Packages.oic.dist
  • python313Packages.pyjwkest
  • python313Packages.pyjwkest.dist

aarch64-darwin (sandbox = false)

✅ 10 packages built:
  • python312Packages.oic
  • python312Packages.oic.dist
  • python312Packages.pyjwkest
  • python312Packages.pyjwkest.dist
  • rucio (python312Packages.rucio)
  • rucio.dist (python312Packages.rucio.dist)
  • python313Packages.oic
  • python313Packages.oic.dist
  • python313Packages.pyjwkest
  • python313Packages.pyjwkest.dist

@Aleksanaa Aleksanaa added this pull request to the merge queue Dec 3, 2025
@Aleksanaa Aleksanaa added the backport release-25.11 Backport PR automatically label Dec 3, 2025
Merged via the queue into NixOS:master with commit 7d60564 Dec 3, 2025
29 of 32 checks passed
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci bot commented Dec 3, 2025

Successfully created backport PR for release-25.11:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. backport release-25.11 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants