Skip to content

fix: Exempt bobby from skiplists - #584

Open
AiyionPrime wants to merge 1 commit into
NixOS:mainfrom
AiyionPrime:fix/update-bobby
Open

AiyionPrime wants to merge 1 commit into
NixOS:mainfrom
AiyionPrime:fix/update-bobby

Conversation

@AiyionPrime

@AiyionPrime AiyionPrime commented Oct 20, 2026 •

Copy link
Copy Markdown

despite being part of teams.gnome-circle.

resolves #583

@AiyionPrime

Copy link
Copy Markdown
Author

@ryantm what's your opinion on this?

@AiyionPrime

This comment was marked as outdated.

despite being part of teams.gnome-circle.

resolves NixOS#583

@rhendric rhendric left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid this doesn't do what you want it to do. There isn't a clean way to have one property (package name) negate a skiplist entry on another property (file contents); we should instead make the teams.gnome entry not catch teams.gnome-circle.

@AiyionPrime

Copy link
Copy Markdown
Author

My bad, I'd hoped that was an early return avoiding the rest :/

Do you have a suggestion how to achieve the behaviour you described instead?

@rhendric

Copy link
Copy Markdown
Member

First, I think you should determine whether projects maintained by both teams.gnome and teams.gnome-circle (e.g. Decibels) are meant to be skipped. If so, I think I'd normalize the file content with T.unwords . T.words before passing it to the skiplist, and then add a space to the end of the GNOME skiplist entry. If not, I'd break the eDSL and expand the GNOME skiplist entry to an explicit tuple, in which the lambda half checks that the text contains "teams.gnome" and does not contain "teams.gnome-".

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updating bobby despite teams.gnome-circle

2 participants