Skip to content

Anchor Settings pickers left so their menus stay inside the pane - #23826

Merged
insomnious merged 2 commits into
masterfrom
fix/settings-picker-placement
Jul 30, 2026
Merged

Anchor Settings pickers left so their menus stay inside the pane#23826
insomnious merged 2 commits into
masterfrom
fix/settings-picker-placement

Conversation

@insomnious

@insomnious insomnious commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

The Picker default placement="right" opens its menu leftward, which the Settings pane's overflow clipping cuts off — the language, multi-user, and update-channel pickers appeared hidden behind the sidebar. Anchor them left (same idiom as the Design System demos); Headless UI v2's auto-positioning will retire the prop later.

Adds an e2e regression test that opens the language picker and hit-tests the menu's corners.

Screenshot 2026-07-29 212730 Screenshot 2026-07-29 212832

@insomnious
insomnious requested review from a team as code owners July 29, 2026 20:33
@insomnious
insomnious requested a review from r1chm8 July 29, 2026 20:34
@insomnious insomnious self-assigned this Jul 29, 2026
@r1chm8

r1chm8 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

When we update headless these elements will be content aware and we won't need to set placement.

@insomnious
insomnious merged commit ad1a916 into master Jul 30, 2026
10 checks passed
@insomnious
insomnious deleted the fix/settings-picker-placement branch July 30, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants