Skip to content

Rename Game settings page header to match sidebar - #23825

Merged
insomnious merged 1 commit into
masterfrom
sd/fix-game-settings-page-header
Jul 30, 2026
Merged

Rename Game settings page header to match sidebar #23825
insomnious merged 1 commit into
masterfrom
sd/fix-game-settings-page-header

Conversation

@insomnious

@insomnious insomnious commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

The sidebar item was renamed to "Game settings" in fba98ff, but only the page registration changed - the page it opened still showed a "Preferences" header.

Sets the header title to "Game settings" and switches the pictogram to settings to match the global Settings page. Two lines in GameSettings.tsx.

image

The per-game sidebar item was renamed from "Preferences" to "Game
settings" in fba98ff, but that commit only changed the page
registration in builtInPages.ts and left the page component untouched.
The sidebar read "Game settings" while the page it opened still showed
a "Preferences" header with the preferences pictogram.

Set the header title to "Game settings" to match the sidebar, and use
the settings pictogram so the page matches the global Settings page.
@insomnious
insomnious requested a review from a team as a code owner July 29, 2026 20:24
@insomnious insomnious changed the title fix: align Game settings page header with its sidebar item Rename Game settings page header to match sidebar Jul 29, 2026
@insomnious insomnious self-assigned this Jul 30, 2026
@insomnious
insomnious merged commit 885b3cb into master Jul 30, 2026
8 checks passed
@insomnious
insomnious deleted the sd/fix-game-settings-page-header branch July 30, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants