Skip to content

Switched to the new upload API for Collections - #22245

Merged
Aragas merged 5 commits into
masterfrom
APP-237
Aug 6, 2026
Merged

Switched to the new upload API for Collections#22245
Aragas merged 5 commits into
masterfrom
APP-237

Conversation

@Aragas

@Aragas Aragas commented Apr 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Closes BLU-247
Closes LAZ-869

  • Replaced the 3-step GraphQL collection upload flow (getRevisionUploadUrl → PUT → createCollection/createOrUpdateRevision) with the new 5-step V3 REST API that supports large file uploads via multipart.
image

@Aragas Aragas self-assigned this Apr 7, 2026
@Aragas
Aragas requested a review from a team as a code owner April 7, 2026 11:15
@Aragas
Aragas marked this pull request as draft April 7, 2026 11:16
@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown

This PR has conflicts. You need to rebase the PR before it can be merged.

@github-actions

github-actions Bot commented Apr 13, 2026

Copy link
Copy Markdown

This PR doesn't have conflicts anymore. It can be merged after all status checks have passed and it has been reviewed.

@Aragas
Aragas marked this pull request as ready for review April 13, 2026 11:59
@Aragas
Aragas marked this pull request as draft April 13, 2026 11:59
@github-actions

github-actions Bot commented Apr 21, 2026

Copy link
Copy Markdown

This PR has conflicts. You need to rebase the PR before it can be merged.

@github-actions

github-actions Bot commented Apr 22, 2026

Copy link
Copy Markdown

This PR doesn't have conflicts anymore. It can be merged after all status checks have passed and it has been reviewed.

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

This PR has conflicts. You need to rebase the PR before it can be merged.

@github-actions

github-actions Bot commented May 14, 2026

Copy link
Copy Markdown

This PR has been marked as stale due to inactivity.

@github-actions

github-actions Bot commented May 18, 2026

Copy link
Copy Markdown

This PR doesn't have conflicts anymore. It can be merged after all status checks have passed and it has been reviewed.

@github-actions

github-actions Bot commented May 18, 2026

Copy link
Copy Markdown

❌ Code is not formatted

To fix this:

  1. Set up the pre-commit hook (prevents future issues):

    pnpm run prepare

    This auto-formats staged files on every commit. (You will never see this error again)

  2. Format all files manually:

    pnpm run format

Then commit the formatting changes. View logs

@Aragas

Aragas commented May 18, 2026

Copy link
Copy Markdown
Member Author

Looks like the commit formatting code isn't working

@github-actions

github-actions Bot commented May 19, 2026

Copy link
Copy Markdown

This PR has conflicts. You need to rebase the PR before it can be merged.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

This PR has been marked as stale due to inactivity.

@Aragas
Aragas marked this pull request as ready for review July 30, 2026 10:31
@Aragas Aragas changed the title Switched to the new upload API Switched to the new upload API for Collections Jul 30, 2026
@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

This PR doesn't have conflicts anymore. It can be merged after all status checks have passed and it has been reviewed.

@Aragas Aragas removed the PR: stale label Jul 30, 2026
erri120
erri120 reviewed Aug 4, 2026
View reviewed changes
Comment thread src/renderer/src/extensions/nexus_integration/util_v3/manifestMapping.ts Outdated
erri120
erri120 requested changes Aug 4, 2026
View reviewed changes
Comment thread src/renderer/src/extensions/nexus_integration/util_v3/uploadV3.ts

@erri120 erri120 Aug 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  1. Uploading, similar to downloading, should be in the main project and use got as well as the existing retry facilities.
  2. Why are we polling for results?

@Aragas Aragas Aug 4, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. That's a solid point, will be implemented
  2. We need the part/parts upload to be finished before calling client.createCollection/client.createCollectionRevision, that's why we wait and see if any error popped up

erri120
erri120 requested changes Aug 5, 2026
View reviewed changes
Comment thread src/shared/src/types/ipc.ts Outdated
@Aragas
Aragas merged commit b29ee98 into master Aug 6, 2026
10 checks passed
@Aragas
Aragas deleted the APP-237 branch August 6, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erri120 erri120 erri120 approved these changes

Assignees

@Aragas Aragas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Aragas @erri120