Skip to content

fix(database): allow nullable resource_id in InMemory and SQLite backends #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
h0ll0w-AkuZr0guY wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(database): allow nullable resource_id in InMemory and SQLite backends #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/memu/database/inmemory/repositories/memory_item_repo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def _find_by_hash(self, content_hash: str, user_data: dict[str, Any]) -> MemoryI
def create_item(
self,
*,
resource_id: str,
resource_id: str | None = None,
memory_type: MemoryType,
summary: str,
embedding: list[float],
Expand Down Expand Up @@ -122,7 +122,7 @@ def create_item(
def create_item_reinforce(
self,
*,
resource_id: str,
resource_id: str | None = None,
memory_type: MemoryType,
summary: str,
embedding: list[float],
Expand Down
2 changes: 1 addition & 1 deletion src/memu/database/repositories/memory_item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def clear_items(self, where: Mapping[str, Any] | None = None) -> dict[str, Memor
def create_item(
self,
*,
resource_id: str,
resource_id: str | None = None,
memory_type: MemoryType,
summary: str,
embedding: list[float],
Expand Down
4 changes: 2 additions & 2 deletions src/memu/database/sqlite/repositories/memory_item_repo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ def clear_items(self, where: Mapping[str, Any] | None = None) -> dict[str, Memor
def create_item(
self,
*,
resource_id: str,
resource_id: str | None = None,
memory_type: MemoryType,
summary: str,
embedding: list[float],
Expand Down Expand Up @@ -285,7 +285,7 @@ def create_item(
def create_item_reinforce(
self,
*,
resource_id: str,
resource_id: str | None = None,
memory_type: MemoryType,
summary: str,
embedding: list[float],
Expand Down