Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3602 +/- ##
==========================================
- Coverage 75.94% 75.84% -0.10%
==========================================
Files 381 381
Lines 34275 34377 +102
==========================================
+ Hits 26030 26074 +44
- Misses 6421 6479 +58
Partials 1824 1824 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a0ce8f5 to
1cf6efc
Compare
RafaelGranza
commented
May 5, 2026
This was referenced May 5, 2026
rodrodros
reviewed
May 6, 2026
Contributor
rodrodros
left a comment
There was a problem hiding this comment.
Looks good, some nitpicks
rodrodros
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the 7 positional boolean flags on
vm.VM.Executewith typed, semantic wrappers, so callers describe what they're doing (Simulate/Trace/BuildBlock) instead of memorizing flag positions.Also breaks down the method into smaller helpers.
Why
vm.Executetakes 7 positionalboolparameters and is invoked from 8 production sites and ~38 test setups. The shape has caused real documentation drift:Every existing call site falls into one of three semantic buckets:
returnInitialReadsvaries)simulate_transactions/estimate_fee(5 flags vary)Notes for reviewers
Executestill exists to bring more options if needed.Executewas broken down into small helperscair_vm_execute.