refactor(feeder): use the new includeSignature flag in the get_state_update feeder endpoint#3601
Draft
thiagodeev wants to merge 8 commits intomainfrom
Draft
refactor(feeder): use the new includeSignature flag in the get_state_update feeder endpoint#3601thiagodeev wants to merge 8 commits intomainfrom
includeSignature flag in the get_state_update feeder endpoint#3601thiagodeev wants to merge 8 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3601 +/- ##
==========================================
+ Coverage 75.87% 75.88% +0.01%
==========================================
Files 387 387
Lines 34918 34914 -4
==========================================
+ Hits 26493 26494 +1
+ Misses 6556 6553 -3
+ Partials 1869 1867 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
77f8e8a to
f5fbdf0
Compare
includeSignature flag in the get_state_update feeder endpoint
d1a4412 to
b9faf76
Compare
… and adjust related tests + new includeSignature for stateUpdateWithBlock feeder inner func
…ate update with block json to include signature
b9faf76 to
b730843
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_state_update+get_signaturefeeder calls into a single request by passingincludeSignature=trueto theget_state_updateendpoint.clients/feeder.Client.StateUpdateWithBlockto accept anincludeSignatureflag and decode the signature directly from the response.adapters/sn2core.AdaptBlockto take[]*felt.Feltinstead of*starknet.Signature.starknet.StateUpdateWithBlockwith an optionalSignature []*felt.Feltfield, populated whenincludeSignature=true.f.client.Signature(ctx, blockID)call instarknetdata/feeder.stateUpdateWithBlock.clients/feeder/testdata/**/state_update_with_block/*.jsonfixtures by adding thesignaturefield to it. The signature values were taken from thesignaturefolderReference: https://demerzelsolutions.slack.com/archives/C03090TS3TK/p1777375140952279
Note: