Improve large request handling - #1793
Merged
Merged
Conversation
/api/login, /api/logout and /api/2fa/otp-verify are reachable without a JWT, and today inherit nginx's global 128 MiB client_max_body_size meant for the authenticated file-upload route. Split these three into exact- match locations with a small client_max_body_size so nginx itself rejects an oversized unauthenticated body with 413 before it ever reaches ns-api-server, independent of any app-level control. Applies to both the default port 443 vhost (00ns.locations) and the optional extra-port vhost generated by the ns-ui init script. Security advisory: GHSA-3v6g-pgp9-cmm7
gsanchietti
force-pushed
the
fix_otp_overflow
branch
from
July 14, 2026 06:39
7c15f1e to
d475d22
Compare
|
Tbaile
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: