Skip to content

fix(ci): skip DO Spaces publish on fork builds, archive packages - #1785

Merged
gsanchietti merged 1 commit into
mainfrom
improve_fork_build
Jul 10, 2026
Merged

fix(ci): skip DO Spaces publish on fork builds, archive packages#1785
gsanchietti merged 1 commit into
mainfrom
improve_fork_build

Conversation

@gsanchietti

@gsanchietti gsanchietti commented Jul 10, 2026

Copy link
Copy Markdown
Member

Summary

  • Fork PR builds never receive DO_SPACE_ACCESS_KEY/DO_SPACE_SECRET_KEY (GitHub withholds secrets from pull_request runs originating from forks, even with secrets: inherit), so the "Copy Packages to repo" rclone step fails auth and the whole job dies even though the image built successfully.
  • Gate the Setup rclone / Copy Packages to repo steps on secret presence.
  • Add a fallback: when secrets aren't available, tar bin/packages and upload it as a packages-archive artifact instead of failing.

Fixes: https://github.com/NethServer/nethsecurity/actions/runs/29031501244/job/86297708834

Fork PR builds never get DO_SPACE_ACCESS_KEY/DO_SPACE_SECRET_KEY (GitHub
withholds secrets from pull_request runs from forks even with
secrets: inherit), so rclone auth fails and the job dies after the image
already built fine. Gate the rclone publish steps on secret presence and
fall back to tarring bin/packages as an uploaded artifact.

Assisted-by: Claude Code:claude-sonnet-5
@gsanchietti gsanchietti self-assigned this Jul 10, 2026
@gsanchietti
gsanchietti marked this pull request as ready for review July 10, 2026 06:27
@gsanchietti
gsanchietti requested a review from Tbaile July 10, 2026 06:27
@gsanchietti
gsanchietti merged commit 0564727 into main Jul 10, 2026
@gsanchietti
gsanchietti deleted the improve_fork_build branch July 10, 2026 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants