Skip to content

fix: removing error notifications #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tbaile wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: removing error notifications #803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 1 addition & 27 deletions src/StandaloneApp.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,12 @@ import StandaloneAppShell from '@/components/standalone/StandaloneAppShell.vue'
import StandaloneAppLogin from '@/components/standalone/StandaloneAppLogin.vue'
import { TOKEN_REFRESH_INTERVAL, useLoginStore } from '@/stores/standalone/standaloneLogin'
import { onMounted, ref } from 'vue'
import axios, { type AxiosRequestConfig, CanceledError } from 'axios'
import axios, { type AxiosRequestConfig } from 'axios'
import { getStandaloneApiEndpoint, isStandaloneMode } from './lib/config'
import { useUnitsStore } from './stores/controller/units'
import { useRoute } from 'vue-router'
import { useI18n } from 'vue-i18n'
import { getPreference } from '@nethesis/vue-components'
import { useNotificationsStore } from './stores/notifications'
import { UnauthorizedAction, useSudoStore } from '@/stores/standalone/sudo.ts'
import AskSudoPasswordModal from '@/components/standalone/AskSudoPasswordModal.vue'
import WizardShell from './views/standalone/wizard/WizardShell.vue'
Expand All @@ -23,7 +22,6 @@ import { VueQueryDevtools } from '@tanstack/vue-query-devtools'

const loginStore = useLoginStore()
const unitsStore = useUnitsStore()
const notificationsStore = useNotificationsStore()
const { locale } = useI18n({ useScope: 'global' })
const route = useRoute()
const sudoStore = useSudoStore()
Expand Down Expand Up @@ -140,30 +138,6 @@ function configureAxios() {
}
}, 200)
})
} else {
// show error notification only if error is not caused from cancellation
// and if it isn't a validation error
// and if it isn't caused by one of the update endpoints because of the system rebooting
// and if it isn't caused by a net::ERR_CONNECTION_REFUSED when applying a migration (probably because of nginx restarting or the machine's ip addresses changing)
if (
!(error instanceof CanceledError) &&
!error.response?.data?.data?.validation?.errors?.length &&
!(
error.config.url.includes('/ubus/call') &&
(JSON.parse(error.config.data)?.method === 'install-uploaded-image' ||
JSON.parse(error.config.data)?.method === 'update-system') &&
// if the error is caused by a system reboot, the response will not have a payload (since it's caused by a net::ERR_CONNECTION_REFUSED)
(!error.response || !error.response.data)
) &&
!(
error.config.url.includes('/ubus/call') &&
(JSON.parse(error.config.data)?.path === 'ns.migration' ||
JSON.parse(error.config.data)?.method === 'upload') &&
(!error.response || !error.response.data)
)
) {
notificationsStore.createNotificationFromAxiosError(error)
}
}
return Promise.reject(error)
}
Expand Down
Loading