Skip to content

Update tag attribution - #133

Merged
ecbadeaux merged 1 commit into
mainfrom
nf-container-attribution
Oct 16, 2026
Merged

ecbadeaux merged 1 commit into
mainfrom
nf-container-attribution

Conversation

@ecbadeaux

@ecbadeaux ecbadeaux commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Title: Read nf.container from NETFLIX_CONTAINER_NAME, falling back to TITUS_CONTAINER_NAME

Summary

nf.container is now read from NETFLIX_CONTAINER_NAME first, falling back to TITUS_CONTAINER_NAME. nf.process is unchanged and still comes from NETFLIX_PROCESS_NAME.

Why

TITUS_CONTAINER_NAME exists only on Titus, so containers on other platforms get no nf.container tag today. NETFLIX_CONTAINER_NAME is a platform-neutral variable that holds the container's name (the Kubernetes container name). Reading it first, with the Titus variable as the fallback, adds coverage for other platforms and leaves Titus unchanged.

Behavior

NETFLIX_CONTAINER_NAME TITUS_CONTAINER_NAME nf.container
app main app
unset, empty or blank main main
app unset app
unset unset not added
  • Same helper as before. It uses the existing add_non_empty helper, which already accepts several variables. Values are trimmed and blank values are skipped, as before.
  • No change on Titus. While NETFLIX_CONTAINER_NAME is unset, the tags are exactly what they are today.
  • Precedence is unchanged. These environment tags still take precedence over extra common tags with the same keys.

Docs

  • tags_from_env_vars doc comment (src/common_tags.ts): lists the variables and the fallback, and says that blank values are ignored.
  • Config doc comment (src/config.ts): says the two tags are read from the environment and take precedence over extra common tags with the same keys.

@ecbadeaux
ecbadeaux merged commit 55a1c26 into main Oct 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant